Upgrade snappy to 1.1.7

[filoozom]

Fixes #521

[filoozom]

Lost one more line for some reason, strange. Shouldn't we move this to a Git Submodule now that I think about it?

[ralphtheninja]

Lost one more line for some reason, strange. Shouldn't we move this to a Git Submodule now that I think about it?

It's probably wise to do so now yes. But might not be completely straight forward. Needs some work to get paths right etc (e.g. snappy.gyp shouldn't use version numbers in path)

[filoozom]

This is actually great because we don't need to push the whole C++ codebase to npm for users that can just make use of prebuild packages.

Just looking for a way to remove all these dependencies after a npm run install, so that these dependencies are deleted once the package is installed as they won't be used anymore. Need to find a way that doesn't make developers lives harder by needing them do download to submodules on each build though.

[filoozom]

I'd like to add something like this to package.json:

{
  "scripts": {
    "make": "git submodule update --init && node-gyp rebuild",
    "install": "prebuild-install || npm run make && git submodule deinit .",
  }
}

(I chose make instead of build because if I add a non-empty build script it automatically runs prebuild for some reason. Maybe this can be fixed?)

This would be nice for users because they wouldn't end up with a few megabytes of useless C++ dependencies, but would require developers and CI to download all git submodules twice. Any ideas?

Except for that, this PR is ready. Maybe I should work on that on another PR actually.

[ralphtheninja]

Actually, I don't think we should do the git submodule update-dance during the install phase. This will cause problems when people are installing it from npm. The code should still be published together with the package, so everything is in the tarball from npm.

[filoozom]

That's a good point. Wouldn't work if installing on a system without git. Guess there's actually no way to make the package smaller after an install then. 🙁

At least this should make it easier to update upstream dependencies (cd deps/snappy/snappy; git checkout $version, commit the thing and there you go).

[ralphtheninja]

At least this should make it easier to update upstream dependencies (cd deps/snappy/snappy; git checkout $version, commit the thing and there you go).

Yes, it's a huge improvement when it comes to maintenance :) We should do this with all code that's vendored, e.g. leveldb and rocksdb as well.

[filoozom]

@ralphtheninja I'm already on it. 😉 Just making sure that all versions are exactly the same and that I'm not overriding a patch or something.

[filoozom]

Okay, this one should be good to go. 👍

Maybe push a test release to check if everything works on npm?

[ralphtheninja]

Maybe push a test release to check if everything works on npm?

Will test tomorrow.

[filoozom]

Hey @ralphtheninja, have you had some time to test this out? If so, I could start working on moving all dependencies to git modules.

[ralphtheninja]

Looks fine, but I think we should document this in README for devs. Someone cloning the repo should probably clone it recursively (or do the git submodule dance)

[ralphtheninja]

Nice!