Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Commit 4ac5004

Browse files
committed
tweaks for rocksdb
1 parent 63f19ea commit 4ac5004

2 files changed

Lines changed: 26 additions & 3 deletions

File tree

src/database.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,10 @@ void Database::CloseDatabase () {
120120
delete db;
121121
db = NULL;
122122
if (blockCache) {
123-
delete blockCache;
123+
// According to
124+
// https://github.com/facebook/rocksdb/wiki/basic-operations#cache
125+
// it doesn't look like this needs to be deleted by hand anymore.
126+
// delete blockCache;
124127
blockCache = NULL;
125128
}
126129
if (filterPolicy) {

src/database_async.cc

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,28 @@ OpenWorker::OpenWorker (
4747
levelOptions.max_open_files = maxOpenFiles;
4848
levelOptions.block_restart_interval = blockRestartInterval;
4949

50-
rocksdb::Options opts = ConvertOptions(levelOptions);
51-
options = &opts;
50+
// rocksdb::Options opts = ConvertOptions(levelOptions);
51+
// options = &opts;
52+
53+
54+
55+
options = new rocksdb::Options();
56+
options->create_if_missing = levelOptions.create_if_missing;
57+
options->error_if_exists = levelOptions.error_if_exists;
58+
options->paranoid_checks = levelOptions.paranoid_checks;
59+
options->env = levelOptions.env;
60+
options->info_log.reset(levelOptions.info_log);
61+
options->write_buffer_size = levelOptions.write_buffer_size;
62+
options->max_open_files = levelOptions.max_open_files;
63+
options->compression = levelOptions.compression;
64+
65+
// rocksdb::BlockBasedTableOptions table_options;
66+
// table_options.block_cache.reset(levelOptions.block_cache);
67+
// table_options.block_size = levelOptions.block_size;
68+
// table_options.block_restart_interval = levelOptions.block_restart_interval;
69+
// table_options.filter_policy.reset(levelOptions.filter_policy);
70+
// options->table_factory.reset(rocksdb::NewBlockBasedTableFactory(levelOptions));
71+
5272
};
5373

5474
OpenWorker::~OpenWorker () {

0 commit comments

Comments
 (0)