Merge pull request #522 from Lombiq/issue/OSOE-1010

sarahelsaig · web-flow · commit c9b6996e7fe4 · 2025-10-24T13:14:02.000Z
OSOE-1010: Updating default Node version to 24.10.0, removing PNPM workaroun
diff --git a/.github/actions/enable-corepack/action.yml b/.github/actions/enable-corepack/action.yml
@@ -1,17 +1,10 @@
 name: Enable corepack
 description: >
-  Enables Node corepack so any package manager can be used seamlessly. This is instead of a direct PNPM install. This
-  step won't be necessary once corepack is out of the experimental state and be enabled by default, see
-  https://github.com/nodejs/node/issues/50963.
-
+  Enables Node corepack so any package manager can be used seamlessly. This is instead of a direct PNPM install.
 runs:
   using: composite
   steps:
     - name: Enable corepack
       shell: pwsh
       run: |
         corepack enable
-
-        # This is really only necessary to work around the https://github.com/nodejs/corepack/issues/612 corepack issue.
-        # Also see https://github.com/Lombiq/NodeJs-Extensions/issues/120.
-        corepack prepare pnpm@8.15.9+sha1.aa4bc353b5f59fe1f1df5d802ce049ddf7f3c60e --activate
diff --git a/.github/actions/publish-nuget/action.yml b/.github/actions/publish-nuget/action.yml
@@ -10,8 +10,6 @@ inputs:
     required: false
     default: minimal
     description: The logging verbosity type used by the `dotnet` command.
-  # This is really only necessary to work around the https://github.com/nodejs/corepack/issues/612 corepack issue.
-  # Also see https://github.com/Lombiq/NodeJs-Extensions/issues/120.
   enable-corepack:
     type: string
     default: 'false'
diff --git a/.github/actions/setup-node/action.yml b/.github/actions/setup-node/action.yml
@@ -12,7 +12,7 @@ inputs:
     default: false
   node-version:
     description: 'Version Spec of the version to use. Examples: 12.x, 10.15.1, >=10.15.0.'
-    default: 22.16.0
+    default: 24.10.0
   node-version-file:
     description: >
       File containing the version Spec of the version to use. Examples: package.json, .nvmrc, .node-version,
diff --git a/.github/workflows/build-and-test-dotnet.yml b/.github/workflows/build-and-test-dotnet.yml
@@ -59,7 +59,7 @@ on:
         description: Version of the .NET SDK to set up.
       node-version:
         type: string
-        default: 22.16.0
+        default: 24.10.0
         description: >
           The Node.js version. Can be a specific version number or other notations, see the documentation of
           https://github.com/actions/setup-node.
diff --git a/.github/workflows/build-and-test-orchard-core.yml b/.github/workflows/build-and-test-orchard-core.yml
@@ -59,7 +59,7 @@ on:
         description: Version of the .NET SDK to set up.
       node-version:
         type: string
-        default: 22.16.0
+        default: 24.10.0
         description: >
           The Node.js version. Can be a specific version number or other notations, see the documentation of
           https://github.com/actions/setup-node.
@@ -70,8 +70,6 @@ on:
           Set to true to enable automatic caching based on the package manager field in package.json. By default,
           caching is disabled for this workflow (which is different from the underlying action's default behavior), to
           improve stability and backwards compatibility.
-      # This is really only necessary to work around the https://github.com/nodejs/corepack/issues/612 corepack issue.
-      # Also see https://github.com/Lombiq/NodeJs-Extensions/issues/120.
       enable-corepack:
         type: string
         default: 'false'
diff --git a/.github/workflows/deploy-orchard1-to-azure-app-service.yml b/.github/workflows/deploy-orchard1-to-azure-app-service.yml
@@ -67,7 +67,7 @@ on:
         description: Version of the .NET SDK to set up.
       node-version:
         type: string
-        default: 22.16.0
+        default: 24.10.0
         description: >
           The Node.js version. Can be a specific version number or other notations, see the documentation of
           https://github.com/actions/setup-node.
diff --git a/.github/workflows/deploy-to-azure-app-service.yml b/.github/workflows/deploy-to-azure-app-service.yml
@@ -50,7 +50,7 @@ on:
         description: Version of the .NET SDK to set up.
       node-version:
         type: string
-        default: 22.16.0
+        default: 24.10.0
         description: >
           The Node.js version. Can be a specific version number or other notations, see the documentation of
           https://github.com/actions/setup-node.
@@ -61,8 +61,6 @@ on:
           Set to true to enable automatic caching based on the package manager field in package.json. By default,
           caching is disabled for this workflow (which is different from the underlying action's default behavior), to
           improve stability and backwards compatibility.
-      # This is really only necessary to work around the https://github.com/nodejs/corepack/issues/612 corepack issue.
-      # Also see https://github.com/Lombiq/NodeJs-Extensions/issues/120.
       enable-corepack:
         type: string
         default: 'false'
diff --git a/.github/workflows/msbuild-and-test.yml b/.github/workflows/msbuild-and-test.yml
@@ -74,7 +74,7 @@ on:
         description: Version of the .NET SDK to set up.
       node-version:
         type: string
-        default: 22.16.0
+        default: 24.10.0
         description: >
           The Node.js version. Can be a specific version number or other notations, see the documentation of
           https://github.com/actions/setup-node.
diff --git a/.github/workflows/publish-nuget.yml b/.github/workflows/publish-nuget.yml
@@ -37,7 +37,7 @@ on:
         description: Version of the .NET SDK to set up.
       node-version:
         type: string
-        default: 22.16.0
+        default: 24.10.0
         description: >
           The Node.js version. Can be a specific version number or other notations, see the documentation of
           https://github.com/actions/setup-node.
@@ -52,8 +52,6 @@ on:
         type: number
         default: 15
         description: Configuration for the timeout-minutes parameter of the workflow. 360 is GitHub's default.
-      # This is really only necessary to work around the https://github.com/nodejs/corepack/issues/612 corepack issue.
-      # Also see https://github.com/Lombiq/NodeJs-Extensions/issues/120.
       enable-corepack:
         type: string
         default: 'false'
diff --git a/.github/workflows/test-analysis-failure.yml b/.github/workflows/test-analysis-failure.yml
@@ -29,7 +29,7 @@ on:
         description: Version of the .NET SDK to set up.
       node-version:
         type: string
-        default: 22.16.0
+        default: 24.10.0
         description: >
           The Node.js version. Can be a specific version number or other notations, see the documentation of
           https://github.com/actions/setup-node.
@@ -40,8 +40,6 @@ on:
           Set to true to enable automatic caching based on the package manager field in package.json. By default,
           caching is disabled for this workflow (which is different from the underlying action's default behavior), to
           improve stability and backwards compatibility.
-      # This is really only necessary to work around the https://github.com/nodejs/corepack/issues/612 corepack issue.
-      # Also see https://github.com/Lombiq/NodeJs-Extensions/issues/120.
       enable-corepack:
         type: string
         default: 'false'
diff --git a/.github/workflows/validate-nuget-publish.yml b/.github/workflows/validate-nuget-publish.yml
@@ -29,7 +29,7 @@ on:
         description: Version of the .NET SDK to set up.
       node-version:
         type: string
-        default: 22.16.0
+        default: 24.10.0
         description: >
           The Node.js version. Can be a specific version number or other notations, see the documentation of
           https://github.com/actions/setup-node.
@@ -44,8 +44,6 @@ on:
         type: number
         default: 15
         description: Configuration for the timeout-minutes parameter of the workflow. 360 is GitHub's default.
-      # This is really only necessary to work around the https://github.com/nodejs/corepack/issues/612 corepack issue.
-      # Also see https://github.com/Lombiq/NodeJs-Extensions/issues/120.
       enable-corepack:
         type: string
         default: 'false'
diff --git a/Readme.md b/Readme.md
@@ -47,6 +47,12 @@ For .NET workflows, the default .NET SDK version we should provide is a concrete
 
 We can still choose to update to a more recent patch version, but only deliberately.
 
+### Default Node.js version
+
+.NET build workflows install the latest Active Long-Term Support (LTS) version of Node.js by default, but the version is configurable. You can check out the [Node.js release schedule](https://nodejs.org/en/about/previous-releases) to see which version is the latest Active LTS at any given time.
+
+Build workflows also enable [corepack](https://github.com/nodejs/corepack) to allow using Node.js package managers other than NPM. This behavior will be disabled when upgrading to Node.js v26 since that version [won't contain corepack anymore](https://github.com/nodejs/node/issues/50963#issuecomment-2746471823).
+
 ### Reference validation
 
 To ensure that when changing actions or workflows their references to other actions/workflows are up-to-date (i.e. instead of `@dev` they reference each other with `@current-branch`) the [Validate GitHub Actions Refs workflow](https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/workflows/validate-this-gha-refs.yml) will fail if references are incorrect. This is the case also if after a pull request approve that references don't point to the target branch; before merging, that should be fixed, otherwise merging via the merge queue will fail.
