Skip to content

Commit 1f0e2fe

Browse files
committed
Added simpleName field to Job model and updated integration tests
Signed-off-by: Michael Collado <collado.mike@gmail.com>
1 parent 9ea2db6 commit 1f0e2fe

11 files changed

Lines changed: 22 additions & 3 deletions

File tree

api/src/main/java/marquez/db/mappers/JobDataMapper.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ public JobData map(@NonNull ResultSet results, @NonNull StatementContext context
3737
JobName.of(stringOrThrow(results, Columns.NAME))),
3838
JobType.valueOf(stringOrThrow(results, Columns.TYPE)),
3939
JobName.of(stringOrThrow(results, Columns.NAME)),
40+
stringOrThrow(results, Columns.SIMPLE_NAME),
4041
timestampOrThrow(results, Columns.CREATED_AT),
4142
timestampOrThrow(results, Columns.UPDATED_AT),
4243
NamespaceName.of(stringOrThrow(results, Columns.NAMESPACE_NAME)),

api/src/main/java/marquez/db/mappers/JobMapper.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public Job map(@NonNull ResultSet results, @NonNull StatementContext context)
4444
JobName.of(stringOrThrow(results, Columns.NAME))),
4545
JobType.valueOf(stringOrThrow(results, Columns.TYPE)),
4646
JobName.of(stringOrThrow(results, Columns.NAME)),
47+
stringOrThrow(results, Columns.SIMPLE_NAME),
4748
timestampOrThrow(results, Columns.CREATED_AT),
4849
timestampOrThrow(results, Columns.UPDATED_AT),
4950
getDatasetFromJsonOrNull(results, "current_inputs"),

api/src/main/java/marquez/db/models/JobData.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ public class JobData implements NodeData {
3131
@NonNull JobId id;
3232
@NonNull JobType type;
3333
@NonNull JobName name;
34+
@NonNull String simpleName;
3435
@NonNull Instant createdAt;
3536
@NonNull Instant updatedAt;
3637
@NonNull NamespaceName namespace;

api/src/main/java/marquez/service/models/Job.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public final class Job {
2626
@Getter private final JobId id;
2727
@Getter private final JobType type;
2828
@Getter private final JobName name;
29+
@Getter private final String simpleName;
2930
@Getter private final Instant createdAt;
3031
@Getter private final Instant updatedAt;
3132
@Getter private final NamespaceName namespace;
@@ -42,6 +43,7 @@ public Job(
4243
@NonNull final JobId id,
4344
@NonNull final JobType type,
4445
@NonNull final JobName name,
46+
@NonNull String simpleName,
4547
@NonNull final Instant createdAt,
4648
@NonNull final Instant updatedAt,
4749
@NonNull final Set<DatasetId> inputs,
@@ -55,6 +57,7 @@ public Job(
5557
this.id = id;
5658
this.type = type;
5759
this.name = name;
60+
this.simpleName = simpleName;
5861
this.createdAt = createdAt;
5962
this.updatedAt = updatedAt;
6063
this.namespace = id.getNamespace();

api/src/test/java/marquez/OpenLineageIntegrationTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,8 @@ public void testOpenLineageJobHierarchyOldAirflowIntegration()
243243
Job job = client.getJob(NAMESPACE_NAME, dagName + "." + task1Name);
244244
assertThat(job)
245245
.isNotNull()
246-
.hasFieldOrPropertyWithValue("id", new JobId(NAMESPACE_NAME, dagName + "." + task1Name));
246+
.hasFieldOrPropertyWithValue("id", new JobId(NAMESPACE_NAME, dagName + "." + task1Name))
247+
.hasFieldOrPropertyWithValue("simpleName", task1Name);
247248

248249
Job parentJob = client.getJob(NAMESPACE_NAME, dagName);
249250
assertThat(parentJob)
@@ -288,13 +289,15 @@ public void testOpenLineageJobHierarchySparkAndAirflow()
288289
Job airflowTask = client.getJob(NAMESPACE_NAME, dagName + "." + task1Name);
289290
assertThat(airflowTask)
290291
.isNotNull()
291-
.hasFieldOrPropertyWithValue("id", new JobId(NAMESPACE_NAME, dagName + "." + task1Name));
292+
.hasFieldOrPropertyWithValue("id", new JobId(NAMESPACE_NAME, dagName + "." + task1Name))
293+
.hasFieldOrPropertyWithValue("simpleName", task1Name);
292294

293295
Job sparkJob = client.getJob(NAMESPACE_NAME, dagName + "." + task1Name + "." + sparkTaskName);
294296
assertThat(sparkJob)
295297
.isNotNull()
296298
.hasFieldOrPropertyWithValue(
297-
"id", new JobId(NAMESPACE_NAME, dagName + "." + task1Name + "." + sparkTaskName));
299+
"id", new JobId(NAMESPACE_NAME, dagName + "." + task1Name + "." + sparkTaskName))
300+
.hasFieldOrPropertyWithValue("simpleName", sparkTaskName);
298301

299302
Job parentJob = client.getJob(NAMESPACE_NAME, dagName);
300303
assertThat(parentJob)

api/src/test/java/marquez/db/mappers/JobMapperTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ public static void setUp() throws SQLException, MalformedURLException {
3737
when(resultSet.getObject(Columns.NAMESPACE_NAME)).thenReturn("NAMESPACE");
3838
when(resultSet.getString(Columns.NAME)).thenReturn("NAME");
3939
when(resultSet.getObject(Columns.NAME)).thenReturn("NAME");
40+
when(resultSet.getString(Columns.SIMPLE_NAME)).thenReturn("SIMPLE_NAME");
41+
when(resultSet.getObject(Columns.SIMPLE_NAME)).thenReturn("SIMPLE_NAME");
4042
when(resultSet.getString(Columns.TYPE)).thenReturn("BATCH");
4143
when(resultSet.getObject(Columns.TYPE)).thenReturn("BATCH");
4244
when(resultSet.getString(Columns.DESCRIPTION)).thenReturn("DESCRIPTION");

api/src/test/resources/mappers/full_job_mapper.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"namespace": "NAMESPACE",
44
"name": "NAME"
55
},
6+
"simpleName": "SIMPLE_NAME",
67
"type": "BATCH",
78
"description": "DESCRIPTION",
89
"name": "NAME",

clients/java/src/main/java/marquez/client/models/Job.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
public final class Job extends JobMeta {
2323
@Getter private final JobId id;
2424
@Getter private final String name;
25+
@Getter private final String simpleName;
2526
@Getter private final Instant createdAt;
2627
@Getter private final Instant updatedAt;
2728
@Getter private final String namespace;
@@ -33,6 +34,7 @@ public Job(
3334
@NonNull final JobId id,
3435
final JobType type,
3536
@NonNull final String name,
37+
@NonNull final String simpleName,
3638
@NonNull final Instant createdAt,
3739
@NonNull final Instant updatedAt,
3840
@NonNull final String namespace,
@@ -47,6 +49,7 @@ public Job(
4749
super(type, inputs, outputs, location, context, description, null);
4850
this.id = id;
4951
this.name = name;
52+
this.simpleName = simpleName;
5053
this.createdAt = createdAt;
5154
this.updatedAt = updatedAt;
5255
this.namespace = namespace;

clients/java/src/test/java/marquez/client/MarquezClientTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ public class MarquezClientTest {
211211
JOB_ID,
212212
JOB_TYPE,
213213
JOB_NAME,
214+
JOB_NAME,
214215
CREATED_AT,
215216
UPDATED_AT,
216217
NAMESPACE_NAME,
@@ -302,6 +303,7 @@ public class MarquezClientTest {
302303
JOB_ID,
303304
JOB_TYPE,
304305
JOB_NAME,
306+
JOB_NAME,
305307
CREATED_AT,
306308
UPDATED_AT,
307309
NAMESPACE_NAME,

clients/java/src/test/java/marquez/client/models/JsonGenerator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,7 @@ public static String newJsonFor(final Job job) {
270270
obj.set("id", id);
271271
obj.put("type", job.getType().toString());
272272
obj.put("name", job.getName());
273+
obj.put("simpleName", job.getName());
273274
obj.put("createdAt", ISO_INSTANT.format(job.getCreatedAt()));
274275
obj.put("updatedAt", ISO_INSTANT.format(job.getUpdatedAt()));
275276
obj.put("namespace", job.getNamespace());

0 commit comments

Comments
 (0)