Skip to content

Commit 1f322b1

Browse files
committed
Merge branch 'ui/add-i18next' of github.com:MarquezProject/marquez into ui/add-i18next
Signed-off-by: Michael Robinson <merobi@gmail.com>
2 parents 4b2984b + 4ab80ec commit 1f322b1

8 files changed

Lines changed: 122 additions & 41 deletions

File tree

.github/dependabot.yml

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
version: 2
2+
updates:
3+
- package-ecosystem: "gradle"
4+
directory: "/"
5+
schedule:
6+
interval: "weekly"
7+
day: "sunday"
8+
labels:
9+
- "dependencies"
10+
- "dependabot"
11+
12+
- package-ecosystem: "gradle"
13+
directory: "clients/java"
14+
schedule:
15+
interval: "weekly"
16+
day: "sunday"
17+
labels:
18+
- "dependencies"
19+
- "dependabot"
20+
21+
- package-ecosystem: "gradle"
22+
directory: "web"
23+
schedule:
24+
interval: "weekly"
25+
day: "sunday"
26+
labels:
27+
- "dependencies"
28+
- "dependabot"
29+
30+
- package-ecosystem: "gradle"
31+
directory: "api"
32+
schedule:
33+
interval: "weekly"
34+
day: "sunday"
35+
labels:
36+
- "dependencies"
37+
- "dependabot"
38+
39+
- package-ecosystem: "docker"
40+
directory: "/"
41+
schedule:
42+
interval: "weekly"
43+
day: "sunday"
44+
labels:
45+
- "dependencies"
46+
- "dependabot"

api/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ plugins {
2323
ext {
2424
jdbi3Version = '3.34.0'
2525
prometheusVersion = '0.16.0'
26-
testcontainersVersion = '1.17.5'
26+
testcontainersVersion = '1.17.6'
2727
sentryVersion = '6.7.0'
2828
}
2929

@@ -56,7 +56,7 @@ dependencies {
5656
testImplementation "org.junit.vintage:junit-vintage-engine:${junit5Version}"
5757
testImplementation "org.testcontainers:postgresql:${testcontainersVersion}"
5858
testImplementation "org.testcontainers:junit-jupiter:${testcontainersVersion}"
59-
testImplementation 'org.apache.httpcomponents:httpclient:4.5.13'
59+
testImplementation 'org.apache.httpcomponents:httpclient:4.5.14'
6060
}
6161

6262
task testUnit(type: Test) {

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ subprojects {
5959
jacocoVersion = '0.8.8'
6060
junit5Version = '5.9.1'
6161
lombokVersion = '1.18.24'
62-
mockitoVersion = '4.8.1'
62+
mockitoVersion = '4.9.0'
6363
openlineageVersion = '0.17.0'
6464
slf4jVersion = '1.7.36'
6565
postgresqlVersion = '42.5.0'

chart/templates/ingress.yaml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
{{- if .Values.ingress.enabled -}}
2+
{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
3+
apiVersion: networking.k8s.io/v1
4+
{{- else if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
5+
apiVersion: networking.k8s.io/v1beta1
6+
{{- else -}}
27
apiVersion: extensions/v1beta1
8+
{{- end }}
39
kind: Ingress
410
metadata:
511
name: {{ include "common.names.fullname" . }}
@@ -15,6 +21,9 @@ metadata:
1521
{{ $key }}: {{ include "common.tplvalues.render" (dict "value" $value "context" $) | quote }}
1622
{{- end }}
1723
spec:
24+
{{- if and .Values.ingress.className (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion) }}
25+
ingressClassName: {{ .Values.ingress.className }}
26+
{{- end }}
1827
{{- if .Values.ingress.tls }}
1928
tls:
2029
{{- range .Values.ingress.tls }}
@@ -31,12 +40,32 @@ spec:
3140
http:
3241
paths:
3342
- path: /api/
43+
{{- if semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion }}
44+
pathType: Prefix
45+
{{- end }}
3446
backend:
47+
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
48+
service:
49+
name: {{ include "common.names.fullname" $ }}
50+
port:
51+
name: http
52+
{{- else }}
3553
serviceName: {{ include "common.names.fullname" $ }}
3654
servicePort: http
55+
{{- end }}
3756
- path: /
57+
{{- if semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion }}
58+
pathType: Prefix
59+
{{- end }}
3860
backend:
61+
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
62+
service:
63+
name: {{ include "common.names.fullname" $ }}-web
64+
port:
65+
name: http
66+
{{- else }}
3967
serviceName: {{ include "common.names.fullname" $ }}-web
4068
servicePort: http
69+
{{- end }}
4170
{{- end }}
4271
{{- end }}

chart/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ postgresql:
107107
## @param image.tag PostgreSQL image tag (immutable tags are recommended)
108108
##
109109
image:
110-
tag: 0.28.0
110+
tag: 12.1.0
111111
## Authentication parameters
112112
## ref: https://github.com/bitnami/bitnami-docker-postgresql/blob/master/README.md#setting-the-root-password-on-first-run
113113
## ref: https://github.com/bitnami/bitnami-docker-postgresql/blob/master/README.md#creating-a-database-on-first-run

clients/java/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ dependencies {
2323
implementation "io.dropwizard:dropwizard-jackson:${dropwizardVersion}"
2424
implementation "org.slf4j:slf4j-api:${slf4jVersion}"
2525
implementation 'org.apache.commons:commons-lang3:3.12.0'
26-
implementation 'org.apache.httpcomponents:httpclient:4.5.13'
26+
implementation 'org.apache.httpcomponents:httpclient:4.5.14'
2727
implementation 'org.apache.maven:maven-archiver:3.6.0'
2828

2929
testImplementation "org.slf4j:slf4j-simple:${slf4jVersion}"

clients/python/marquez_client/client.py

Lines changed: 30 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,18 @@ def get_job_run(self, run_id):
343343
Utils.is_valid_uuid(run_id, 'run_id')
344344
return self._get(self._url('/jobs/runs/{0}', run_id))
345345

346-
def get_column_lineage_by_dataset(self, namespace, dataset, depth=None, with_downstream=None):
347-
node_id = "dataset:{0}:{1}".format(namespace, dataset)
346+
def get_column_lineage_by_dataset(
347+
self,
348+
namespace,
349+
dataset,
350+
depth=None,
351+
with_downstream=None,
352+
version=None
353+
):
354+
node_id = self._append_version_to_node_id(
355+
"dataset:{0}:{1}".format(namespace, dataset),
356+
version
357+
)
348358
return self._get_column_lineage(node_id, depth, with_downstream)
349359

350360
def get_column_lineage_by_dataset_field(
@@ -353,15 +363,29 @@ def get_column_lineage_by_dataset_field(
353363
dataset,
354364
field,
355365
depth=None,
356-
with_downstream=None
366+
with_downstream=None,
367+
version=None,
357368
):
358-
node_id = "datasetField:{0}:{1}:{2}".format(namespace, dataset, field)
369+
node_id = self._append_version_to_node_id(
370+
"datasetField:{0}:{1}:{2}".format(namespace, dataset, field),
371+
version
372+
)
359373
return self._get_column_lineage(node_id, depth, with_downstream)
360374

361-
def get_column_lineage_by_job(self, namespace, job, depth=None, with_downstream=None):
362-
node_id = "job:{0}:{1}".format(namespace, job)
375+
def get_column_lineage_by_job(self, namespace, job, depth=None,
376+
with_downstream=None, version=None):
377+
node_id = self._append_version_to_node_id(
378+
"job:{0}:{1}".format(namespace, job),
379+
version
380+
)
363381
return self._get_column_lineage(node_id, depth, with_downstream)
364382

383+
def _append_version_to_node_id(self, node_id, version):
384+
if version is not None:
385+
return node_id + "#" + version
386+
else:
387+
return node_id
388+
365389
def _get_column_lineage(self, node_id, depth, with_downstream):
366390
return self._get(
367391
self._url('/column-lineage'),

clients/python/tests/test_marquez_client.py

Lines changed: 12 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -979,21 +979,16 @@ def test_get_column_lineage_by_dataset(mock_get, client):
979979
mock_get.return_value.json.return_value = COLUMN_LINEAGE
980980

981981
column_lineage = client.get_column_lineage_by_dataset(
982-
"namespace_a",
983-
"dataset_a",
984-
DEFAULT_DEPTH,
985-
DEFAULT_WITH_DOWNSTREAM
982+
namespace="namespace_a", dataset="dataset_a", depth=DEFAULT_DEPTH,
983+
with_downstream=DEFAULT_WITH_DOWNSTREAM, version="some-version"
986984
)
987985

988986
assert column_lineage == COLUMN_LINEAGE
989-
990987
mock_get.assert_called_once_with(
991-
url=client._url(
992-
'/column-lineage'
993-
),
988+
url=client._url('/column-lineage'),
994989
headers=mock.ANY,
995990
params={
996-
'nodeId': 'dataset:namespace_a:dataset_a',
991+
'nodeId': 'dataset:namespace_a:dataset_a#some-version',
997992
'depth': DEFAULT_DEPTH,
998993
'withDownstream': DEFAULT_WITH_DOWNSTREAM
999994
},
@@ -1005,24 +1000,17 @@ def test_get_column_lineage_by_dataset(mock_get, client):
10051000
def test_get_column_lineage_by_dataset_field(mock_get, client):
10061001
mock_get.return_value.status_code.return_value = HTTPStatus.OK
10071002
mock_get.return_value.json.return_value = COLUMN_LINEAGE
1008-
10091003
column_lineage = client.get_column_lineage_by_dataset_field(
1010-
"namespace_a",
1011-
"dataset_a",
1012-
"field_a",
1013-
DEFAULT_DEPTH,
1014-
DEFAULT_WITH_DOWNSTREAM
1004+
namespace="namespace_a", dataset="dataset_a", field="field_a", depth=DEFAULT_DEPTH,
1005+
with_downstream=DEFAULT_WITH_DOWNSTREAM, version="some-version"
10151006
)
10161007

10171008
assert column_lineage == COLUMN_LINEAGE
1018-
10191009
mock_get.assert_called_once_with(
1020-
url=client._url(
1021-
'/column-lineage'
1022-
),
1010+
url=client._url('/column-lineage'),
10231011
headers=mock.ANY,
10241012
params={
1025-
'nodeId': 'datasetField:namespace_a:dataset_a:field_a',
1013+
'nodeId': 'datasetField:namespace_a:dataset_a:field_a#some-version',
10261014
'depth': DEFAULT_DEPTH,
10271015
'withDownstream': DEFAULT_WITH_DOWNSTREAM
10281016
},
@@ -1034,23 +1022,17 @@ def test_get_column_lineage_by_dataset_field(mock_get, client):
10341022
def test_get_column_lineage_by_job(mock_get, client):
10351023
mock_get.return_value.status_code.return_value = HTTPStatus.OK
10361024
mock_get.return_value.json.return_value = COLUMN_LINEAGE
1037-
10381025
column_lineage = client.get_column_lineage_by_job(
1039-
"namespace_a",
1040-
"job_a",
1041-
DEFAULT_DEPTH,
1042-
DEFAULT_WITH_DOWNSTREAM
1026+
namespace="namespace_a", job="job_a", depth=DEFAULT_DEPTH,
1027+
with_downstream=DEFAULT_WITH_DOWNSTREAM, version="some-version"
10431028
)
10441029

10451030
assert column_lineage == COLUMN_LINEAGE
1046-
10471031
mock_get.assert_called_once_with(
1048-
url=client._url(
1049-
'/column-lineage'
1050-
),
1032+
url=client._url('/column-lineage'),
10511033
headers=mock.ANY,
10521034
params={
1053-
'nodeId': 'job:namespace_a:job_a',
1035+
'nodeId': 'job:namespace_a:job_a#some-version',
10541036
'depth': DEFAULT_DEPTH,
10551037
'withDownstream': DEFAULT_WITH_DOWNSTREAM
10561038
},

0 commit comments

Comments
 (0)