Skip to content

Commit 33d74d8

Browse files
author
phix
committed
Icons for jobs and datasets on lineage panels.
1 parent 2a6eddc commit 33d74d8

2 files changed

Lines changed: 52 additions & 6 deletions

File tree

web/src/components/datasets/DatasetDetailPage.tsx

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
import { CalendarIcon } from '@mui/x-date-pickers'
1717
import { CircularProgress } from '@mui/material'
1818
import { Dataset, DatasetVersion } from '../../types/api'
19+
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
1920
import { IState } from '../../store/reducers'
2021
import { LineageDataset } from '../../types/lineage'
2122
import { MqInfo } from '../core/info/MqInfo'
@@ -32,7 +33,9 @@ import {
3233
resetDatasetVersions,
3334
setTabIndex,
3435
} from '../../store/actionCreators'
36+
import { faDatabase } from '@fortawesome/free-solid-svg-icons'
3537
import { formatUpdatedAt } from '../../helpers'
38+
import { truncateText } from '../../helpers/text'
3639
import { useNavigate, useSearchParams } from 'react-router-dom'
3740
import { useTheme } from '@emotion/react'
3841
import CloseIcon from '@mui/icons-material/Close'
@@ -159,9 +162,29 @@ const DatasetDetailPage: FunctionComponent<IProps> = (props) => {
159162
)}
160163
<Box display={'flex'} alignItems={'center'}>
161164
<Box>
162-
<MqText heading font={'mono'}>
163-
{name}
164-
</MqText>
165+
<Box display={'flex'} alignItems={'center'}>
166+
<Box
167+
mr={2}
168+
borderRadius={theme.spacing(1)}
169+
p={1}
170+
width={32}
171+
height={32}
172+
display={'flex'}
173+
bgcolor={theme.palette.info.main}
174+
>
175+
<FontAwesomeIcon
176+
aria-hidden={'true'}
177+
title={'Dataset'}
178+
icon={faDatabase}
179+
width={16}
180+
height={16}
181+
color={theme.palette.common.white}
182+
/>
183+
</Box>
184+
<MqText font={'mono'} heading>
185+
{truncateText(name, 40)}
186+
</MqText>
187+
</Box>
165188
<MqText subdued>{description}</MqText>
166189
</Box>
167190
</Box>

web/src/components/jobs/JobDetailPage.tsx

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import * as Redux from 'redux'
88
import { Box, Button, CircularProgress, Divider, Grid, Tab, Tabs } from '@mui/material'
99
import { CalendarIcon } from '@mui/x-date-pickers'
1010
import { DirectionsRun, SportsScore, Start } from '@mui/icons-material'
11+
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
1112
import { IState } from '../../store/reducers'
1213
import { LineageJob } from '../../types/lineage'
1314
import { MqInfo } from '../core/info/MqInfo'
@@ -23,9 +24,11 @@ import {
2324
resetRuns,
2425
setTabIndex,
2526
} from '../../store/actionCreators'
27+
import { faCog } from '@fortawesome/free-solid-svg-icons/faCog'
2628
import { formatUpdatedAt } from '../../helpers'
2729
import { jobRunsStatus } from '../../helpers/nodes'
2830
import { stopWatchDuration } from '../../helpers/time'
31+
import { truncateText } from '../../helpers/text'
2932
import { useNavigate, useSearchParams } from 'react-router-dom'
3033
import { useTheme } from '@emotion/react'
3134
import CloseIcon from '@mui/icons-material/Close'
@@ -118,9 +121,29 @@ const JobDetailPage: FunctionComponent<IProps> = (props) => {
118121
>
119122
<Box display={'flex'} alignItems={'center'} justifyContent={'space-between'}>
120123
<Box>
121-
<MqText font={'mono'} heading>
122-
{job.name}
123-
</MqText>
124+
<Box display={'flex'} alignItems={'center'}>
125+
<Box
126+
mr={2}
127+
borderRadius={theme.spacing(1)}
128+
p={1}
129+
width={32}
130+
height={32}
131+
display={'flex'}
132+
bgcolor={theme.palette.primary.main}
133+
>
134+
<FontAwesomeIcon
135+
aria-hidden={'true'}
136+
title={'Job'}
137+
icon={faCog}
138+
width={16}
139+
height={16}
140+
color={theme.palette.common.white}
141+
/>
142+
</Box>
143+
<MqText font={'mono'} heading>
144+
{truncateText(job.name, 40)}
145+
</MqText>
146+
</Box>
124147
{job.description && (
125148
<Box mt={1}>
126149
<MqText subdued>{job.description}</MqText>

0 commit comments

Comments
 (0)