Skip to content

Commit 64d8cd0

Browse files
authored
Show facets even when dataset has no fields. (#2214)
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> Use ternary logic. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
1 parent db92c4f commit 64d8cd0

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

web/src/components/datasets/DatasetInfo.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,10 @@ interface DatasetInfoProps {
2121
const DatasetInfo: FunctionComponent<DatasetInfoProps> = props => {
2222
const { datasetFields, facets, run } = props
2323

24-
if (datasetFields.length === 0) {
25-
return <MqEmpty title={'No Fields'} body={'Try adding dataset fields.'} />
26-
}
27-
2824
return (
2925
<Box>
26+
{datasetFields.length === 0 && <MqEmpty title={'No Fields'} body={'Try adding dataset fields.'} />}
27+
{datasetFields.length > 0 && (
3028
<Table size='small'>
3129
<TableHead>
3230
<TableRow>
@@ -53,6 +51,7 @@ const DatasetInfo: FunctionComponent<DatasetInfoProps> = props => {
5351
})}
5452
</TableBody>
5553
</Table>
54+
)}
5655
{facets && (
5756
<Box mt={2}>
5857
<Box mb={1}>

0 commit comments

Comments
 (0)