add tests

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

Author: jlukenoff

web/src/__tests__/components/Lineage.test.tsx

@@ -20,23 +20,24 @@ class MockNode implements Partial<LineageNode> {
   inEdges: MockEdge[]
   outEdges: MockEdge[]
 
-  constructor(id, [prev, next]: [string | null, string | null]) {
+  constructor(id, prev: string[], next: string[]) {
     this.id = id
-    this.inEdges = prev ? [new MockEdge(prev, id)] : ([] as MockEdge[])
-    this.outEdges = next ? [new MockEdge(id, next)] : ([] as MockEdge[])
+    this.inEdges = prev ? prev.map(p => new MockEdge(p, id)) : ([] as MockEdge[])
+    this.outEdges = next ? next.map(n => new MockEdge(id, n)) : ([] as MockEdge[])
   }
 }
 
 const mockGraphWithCycle = [
-  new MockNode('1', ['3', '2']),
-  new MockNode('2', ['1', '3']),
-  new MockNode('3', ['2', '1'])
+  new MockNode('1', ['3'], ['2']),
+  new MockNode('2', ['1'], ['3']),
+  new MockNode('3', ['2'], ['1'])
 ] as LineageNode[]
 
 const mockGraphWithoutCycle = [
-  new MockNode('1', [null, '2']),
-  new MockNode('2', ['1', '3']),
-  new MockNode('3', ['2', null])
+  new MockNode('1', [], ['2', '4']),
+  new MockNode('2', ['1'], ['3']),
+  new MockNode('3', ['2'], []),
+  new MockNode('4', ['1'], [])
 ] as LineageNode[]
 
 describe('Lineage Component', () => {
@@ -74,10 +75,27 @@ describe('Lineage Component', () => {
     const expectedPaths = [
       ['1', '2'],
       ['2', '3'],
-      ['3', '2'],
-      ['2', '1']
+      ['3', '1'],
+      ['3', '1'],
+      ['2', '3'],
+      ['1', '2']
     ]
 
     expect(actualPaths).toEqual(expectedPaths)
   })
+
+  it('includes nodes in selected path when fullGraph is true', () => {
+    const g = initGraph()
+    buildGraphAll(g, mockGraphWithoutCycle, true, '3', () => null)
+
+    expect(g.node('4')).toBeDefined()
+  })
+
+  it('exclude nodes not in selected path when fullGraph is false', () => {
+    const g = initGraph()
+
+    buildGraphAll(g, mockGraphWithoutCycle, false, '3', () => null)
+
+    expect(g.node('4')).toBeUndefined()
+  })
 })

web/src/components/lineage/Lineage.tsx

@@ -119,7 +119,7 @@ export function getSelectedPaths(g: graphlib.Graph<MqNode>, selectedNode: string
 
     const successors = g?.successors(node)
     if (successors?.length) {
-      for (let i = 0; i < node.length - 1; i++) {
+      for (let i = 0; i < successors.length; i++) {
         if (successors[i]) {
           paths.push([node, (successors[i] as unknown) as string])
           getSuccessors((successors[i] as unknown) as string)
@@ -134,7 +134,7 @@ export function getSelectedPaths(g: graphlib.Graph<MqNode>, selectedNode: string
 
     const predecessors = g?.predecessors(node)
     if (predecessors?.length) {
-      for (let i = 0; i < node.length - 1; i++) {
+      for (let i = 0; i < predecessors.length; i++) {
         if (predecessors[i]) {
           paths.push([(predecessors[i] as unknown) as string, node])
           getPredecessors((predecessors[i] as unknown) as string)