Skip to content

Commit d6cf5af

Browse files
authored
fix: Correct SQL query pagination for DatasetVersion findAll method (#2945)
Signed-off-by: Alper İnan <kurumsal.alper@gmail.com> Signed-off-by: Alper <kurumsal.alper@gmail.com>
1 parent 2ffe5aa commit d6cf5af

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

api/src/main/java/marquez/db/DatasetVersionDao.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,6 @@ LEFT JOIN (
277277
) f ON f.dataset_version_uuid = dv.uuid
278278
WHERE dv.namespace_name = :namespaceName
279279
AND dv.dataset_name = :datasetName
280-
LIMIT :limit OFFSET :offset
281280
),
282281
dataset_symlinks_names as (
283282
SELECT DISTINCT dataset_uuid, name
@@ -295,6 +294,7 @@ WHERE name NOT IN (SELECT name FROM dataset_symlinks_names)
295294
created_at, version, dataset_schema_version_uuid, fields, createdByRunUuid, schema_location,
296295
tags, dataset_version_uuid
297296
ORDER BY created_at DESC
297+
LIMIT :limit OFFSET :offset
298298
""")
299299
List<DatasetVersion> findAll(String namespaceName, String datasetName, int limit, int offset);
300300

0 commit comments

Comments
 (0)