user source to metadata source go to line

Author: MattParkerDev

src/SharpIDE.Application/Features/Analysis/RoslynAnalysis.cs

@@ -1002,7 +1002,7 @@ public async Task<ImmutableArray<IdeReferenceLocationResult>> GetIdeReferenceLoc
 		return document.FilePath;
 	}
 
-	public async Task<string?> GetMetadataAsSource(SharpIdeFile currentFile, ISymbol symbol, CancellationToken cancellationToken = default)
+	public async Task<(string FilePath, Location Location)?> GetMetadataAsSourceForSymbol(SharpIdeFile currentFile, ISymbol symbol, CancellationToken cancellationToken = default)
 	{
 		using var _ = SharpIdeOtel.Source.StartActivity($"{nameof(RoslynAnalysis)}.{nameof(FindAllSymbolReferences)}");
 		await _solutionLoadedTcs.Task;
@@ -1015,8 +1015,10 @@ public async Task<ImmutableArray<IdeReferenceLocationResult>> GetIdeReferenceLoc
 		Console.WriteLine(metadataAsSourceFile.FilePath);
 		var metadataAsSourceWorkspace = _metadataAsSourceFileService.TryGetWorkspace();
 		var documentId = metadataAsSourceWorkspace!.CurrentSolution.GetDocumentIdsWithFilePath(metadataAsSourceFile.FilePath).SingleOrDefault();
-		var document = metadataAsSourceWorkspace.CurrentSolution.GetDocument(documentId);
-		return document?.FilePath;
+		if (documentId is null) return null;
+		var document = await metadataAsSourceWorkspace.CurrentSolution.GetRequiredDocumentAsync(documentId, cancellationToken);
+		if (document.FilePath is null) return null;
+		return (document.FilePath, metadataAsSourceFile.IdentifierLocation);
 	}
 
 	public async Task<ImmutableArray<ReferencedSymbol>> FindAllSymbolReferences(ISymbol symbol, CancellationToken cancellationToken = default)

src/SharpIDE.Application/Features/Analysis/SharpIdeMetadataAsSourceService.cs

@@ -8,15 +8,16 @@ public class SharpIdeMetadataAsSourceService(RoslynAnalysis roslynAnalysis)
 	private readonly RoslynAnalysis _roslynAnalysis = roslynAnalysis;
 	private readonly Dictionary<string, SharpIdeFile> _metadataAsSourceFileCache = [];
 
-	public async Task<SharpIdeFile?> CreateSharpIdeFileForMetadataAsSourceAsync(SharpIdeFile currentFile, ISymbol referencedSymbol)
+	public async Task<(SharpIdeFile, Location)?> CreateSharpIdeFileForMetadataAsSourceAsync(SharpIdeFile currentFile, ISymbol referencedSymbol)
 	{
-		var filePath = await _roslynAnalysis.GetMetadataAsSource(currentFile, referencedSymbol);
-		if (filePath is null) return null;
+		var result = await _roslynAnalysis.GetMetadataAsSourceForSymbol(currentFile, referencedSymbol);
+		if (result is null) return null;
+		var (filePath, requestedSymbolLocation) = result.Value;
 		var fileFromCache = _metadataAsSourceFileCache.GetValueOrDefault(filePath);
-		if (fileFromCache is not null) return fileFromCache;
+		if (fileFromCache is not null) return (fileFromCache, requestedSymbolLocation);
 		var metadataAsSourceSharpIdeFile = new SharpIdeFile(filePath, Path.GetFileName(filePath), Path.GetExtension(filePath), null!, [], true);
 		_metadataAsSourceFileCache[filePath] = metadataAsSourceSharpIdeFile;
-		return metadataAsSourceSharpIdeFile;
+		return (metadataAsSourceSharpIdeFile, requestedSymbolLocation);
 	}
 
 	public async Task<SharpIdeFile?> GetOrCreateSharpIdeFileForAlreadyDecompiledMetadataAsSourceAsync(string filePath)

src/SharpIDE.Godot/Features/CodeEditor/SharpIdeCodeEdit_SymbolLookup.cs

@@ -99,10 +99,13 @@ await this.InvokeAsync(() =>
                     else
                     {
                         GD.Print($"Definition is not in source code, attempting to navigate to metadata as source: {referencedSymbol.Name}");
-                        var metadataAsSourceSharpIdeFile = await _sharpIdeMetadataAsSourceService.CreateSharpIdeFileForMetadataAsSourceAsync(_currentFile, referencedSymbol);
-                        if (metadataAsSourceSharpIdeFile is not null)
+                        var result = await _sharpIdeMetadataAsSourceService.CreateSharpIdeFileForMetadataAsSourceAsync(_currentFile, referencedSymbol);
+                        if (result is not null)
                         {
-                            await GodotGlobalEvents.Instance.FileExternallySelected.InvokeParallelAsync(metadataAsSourceSharpIdeFile, new SharpIdeFileLinePosition(0, 0));
+                            var (metadataAsSourceSharpIdeFile, location) = result.Value;
+                            var definitionInMetadataSourceLineSpan = location.GetMappedLineSpan();
+                            var linePosition = new SharpIdeFileLinePosition(definitionInMetadataSourceLineSpan.Span.Start.Line, definitionInMetadataSourceLineSpan.Span.Start.Character);
+                            await GodotGlobalEvents.Instance.FileExternallySelected.InvokeParallelAsync(metadataAsSourceSharpIdeFile, linePosition);
                         }
                         else
                         {