update aspire instructions for godot

Author: MattParkerDev

tools/AppHost/GodotExtensions.cs

@@ -24,7 +24,6 @@ public static IResourceBuilder<ExecutableResource> AddGodot(
     {
         name ??= Path.GetFileNameWithoutExtension(projectPath);
         var projectDirectory = Path.GetDirectoryName(projectPath) ?? ".";
-        var godotPath = GetGodotExecutablePath();
 
         // Build the arguments list
         var arguments = new List<string>
@@ -40,10 +39,9 @@ public static IResourceBuilder<ExecutableResource> AddGodot(
         // Create a standard ExecutableResource (since custom ones don't seem to work well)
         var godotResource = builder.AddExecutable(
             name: name,
-            command: godotPath,
+            command: "godot",
             workingDirectory: projectDirectory,
             args: arguments.ToArray());
-            //.WithEnvironment("OTEL_EXPORTER_OTLP_ENDPOINT", Environment.GetEnvironmentVariable("OTEL_EXPORTER_OTLP_ENDPOINT") ?? throw new InvalidOperationException("OTEL_EXPORTER_OTLP_ENDPOINT environment variable is not set"));
 
         // Add a lifecycle hook to handle building before startup
         builder.Services.AddSingleton<IDistributedApplicationEventingSubscriber>(sp =>
@@ -55,35 +53,6 @@ public static IResourceBuilder<ExecutableResource> AddGodot(
         return godotResource;
     }
 
-    /// <summary>
-    /// Gets the Godot executable path based on the current platform.
-    /// </summary>
-    private static string GetGodotExecutablePath()
-    {
-        // First check for GODOT environment variable
-        var godotPath = Environment.GetEnvironmentVariable("GODOT");
-        if (!string.IsNullOrWhiteSpace(godotPath))
-        {
-            return godotPath;
-        }
-
-        // Fallback to platform-specific defaults
-        if (OperatingSystem.IsMacOS())
-        {
-            return "godot";
-        }
-        else if (OperatingSystem.IsWindows())
-        {
-            return "godot.exe";
-        }
-        else if (OperatingSystem.IsLinux())
-        {
-            return "godot";
-        }
-
-        throw new PlatformNotSupportedException("Current platform is not supported for Godot execution.");
-    }
-
     private class GodotBuildEventSubscriber : IDistributedApplicationEventingSubscriber
     {
         private readonly string _projectPath;

tools/AppHost/Properties/launchSettings.json

@@ -10,8 +10,7 @@
         "ASPNETCORE_ENVIRONMENT": "Development",
         "DOTNET_ENVIRONMENT": "Development",
         "DOTNET_DASHBOARD_OTLP_ENDPOINT_URL": "https://localhost:21295",
-        "DOTNET_RESOURCE_SERVICE_ENDPOINT_URL": "https://localhost:22130",
-		"GODOT": "C:/Users/Matthew/Documents/Godot/Path/godot.exe"
+        "DOTNET_RESOURCE_SERVICE_ENDPOINT_URL": "https://localhost:22130"
       }
     }
   }

tools/AppHost/README.md

@@ -3,6 +3,9 @@
 Running SharpIDE via the Aspire AppHost allows you to inspect the OTEL telemetry and logs
 
 ### Setup
-1. Replace `GODOT` environment variable with the path to your executable in launchSettings.json
+1. Download the latest godot (.NET) binary, and put it somewhere (e.g. Documents/Godot/Path)
+2. Rename e.g. Godot_v4.6.1-stable_mono_win64.exe to godot.exe
+3. Put the folder containing the godot executable on your PATH, and ensure it resolves from a shell
+4. Done - Aspire will launch godot via the executable on the PATH
 
 TODO: Create better godot integration with aspire/wait for libgodot.