ignore file changes not in workspace

Author: MattParkerDev

src/SharpIDE.Application/Features/Analysis/RoslynAnalysis.cs

@@ -920,7 +920,8 @@ public async Task<ImmutableArray<ReferencedSymbol>> FindAllSymbolReferences(ISym
 		return null;
 	}
 
-	public async Task UpdateDocument(SharpIdeFile fileModel, string newContent)
+	// Returns true if the document was found and updated, otherwise false
+	public async Task<bool> UpdateDocument(SharpIdeFile fileModel, string newContent)
 	{
 		using var _ = SharpIdeOtel.Source.StartActivity($"{nameof(RoslynAnalysis)}.{nameof(UpdateDocument)}");
 		await _solutionLoadedTcs.Task;
@@ -937,7 +938,7 @@ public async Task UpdateDocument(SharpIdeFile fileModel, string newContent)
 		if (documentId is null)
 		{
 			_logger.LogWarning("UpdateDocument failed: Document '{DocumentPath}' not found in workspace", fileModel.Path);
-			return;
+			return false;
 		}
 
 		var newText = SourceText.From(newContent, Encoding.UTF8);
@@ -957,6 +958,11 @@ public async Task UpdateDocument(SharpIdeFile fileModel, string newContent)
 		{
 			_workspace.OnAnalyzerConfigDocumentTextChanged(documentId, newText, PreservationMode.PreserveIdentity);
 		}
+		else
+		{
+			return false;
+		}
+		return true;
 	}
 
 	public async Task AddDocument(SharpIdeFile fileModel, string content)
@@ -1022,7 +1028,7 @@ public async Task AddDocument(SharpIdeFile fileModel, string content)
 		}, WorkspaceChangeKind.DocumentAdded, documentId: documentId);
 	}
 
-	public async Task RemoveDocument(SharpIdeFile fileModel)
+	public async Task<bool> RemoveDocument(SharpIdeFile fileModel)
 	{
 		using var _ = SharpIdeOtel.Source.StartActivity($"{nameof(RoslynAnalysis)}.{nameof(AddDocument)}");
 		await _solutionLoadedTcs.Task;
@@ -1038,7 +1044,7 @@ public async Task RemoveDocument(SharpIdeFile fileModel)
 		if (documentId is null)
 		{
 			_logger.LogWarning("RemoveDocument failed: Document '{DocumentPath}' not found in workspace", fileModel.Path);
-			return;
+			return false;
 		}
 		var documentKind = _workspace.CurrentSolution.GetDocumentKind(documentId);
 		Guard.Against.Null(documentKind);
@@ -1050,6 +1056,7 @@ public async Task RemoveDocument(SharpIdeFile fileModel)
 			case TextDocumentKind.AnalyzerConfigDocument: _workspace.OnAnalyzerConfigDocumentRemoved(documentId); break;
 			default: throw new ArgumentOutOfRangeException(nameof(documentKind));
 		}
+		return true;
 	}
 
 	public async Task MoveDocument(SharpIdeFile sharpIdeFile, string oldFilePath)

src/SharpIDE.Application/Features/FileWatching/FileChangedService.cs

@@ -132,7 +132,8 @@ private async Task HandleCsprojChanged(SharpIdeFile file)
 
 	private async Task HandleWorkspaceFileChanged(SharpIdeFile file, string newContents)
 	{
-		await _roslynAnalysis.UpdateDocument(file, newContents);
+		var fileUpdatedInWorkspace = await _roslynAnalysis.UpdateDocument(file, newContents);
+		if (fileUpdatedInWorkspace is false) return;
 		GlobalEvents.Instance.SolutionAltered.InvokeParallelFireAndForget();
 		_updateSolutionDiagnosticsQueue.AddWork();
 	}
@@ -146,7 +147,8 @@ private async Task HandleWorkspaceFileAdded(SharpIdeFile file, string contents)
 
 	private async Task HandleWorkspaceFileRemoved(SharpIdeFile file)
 	{
-		await _roslynAnalysis.RemoveDocument(file);
+		var success = await _roslynAnalysis.RemoveDocument(file);
+		if (success is false) return;
 		GlobalEvents.Instance.SolutionAltered.InvokeParallelFireAndForget();
 		_updateSolutionDiagnosticsQueue.AddWork();
 	}