Skip to content

Commit 9d5db0c

Browse files
fix: remove duplicate/dead config resolvers in feature_configs.py (fixes #1997) (#2000)
- Remove duplicate resolve_output and resolve_execution from feature_configs.py - These functions are shadowed by param_resolver versions (public API uses param_resolver) - The removed functions contained a latent bug calling non-existent from_preset methods - Keep canonical implementations in param_resolver as single source of truth Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com> Co-authored-by: MervinPraison <MervinPraison@users.noreply.github.com>
1 parent f2b6297 commit 9d5db0c

1 file changed

Lines changed: 0 additions & 35 deletions

File tree

src/praisonai-agents/praisonaiagents/config/feature_configs.py

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1451,39 +1451,6 @@ def resolve_web(value: WebParam) -> Optional[WebConfig]:
14511451
return value
14521452

14531453

1454-
def resolve_output(value: OutputParam) -> Optional[OutputConfig]:
1455-
"""Resolve output= parameter following precedence ladder."""
1456-
if value is None:
1457-
return None
1458-
if isinstance(value, str):
1459-
try:
1460-
preset = OutputPreset(value.lower())
1461-
return OutputConfig.from_preset(preset)
1462-
except ValueError:
1463-
return None
1464-
if isinstance(value, dict):
1465-
return OutputConfig(**value)
1466-
if isinstance(value, OutputConfig):
1467-
return value
1468-
return value
1469-
1470-
1471-
def resolve_execution(value: ExecutionParam) -> Optional[ExecutionConfig]:
1472-
"""Resolve execution= parameter following precedence ladder."""
1473-
if value is None:
1474-
return None
1475-
if isinstance(value, str):
1476-
try:
1477-
preset = ExecutionPreset(value.lower())
1478-
return ExecutionConfig.from_preset(preset)
1479-
except ValueError:
1480-
return None
1481-
if isinstance(value, dict):
1482-
return ExecutionConfig(**value)
1483-
if isinstance(value, ExecutionConfig):
1484-
return value
1485-
return value
1486-
14871454

14881455
def resolve_caching(value: CachingParam) -> Optional[CachingConfig]:
14891456
"""Resolve caching= parameter following precedence ladder."""
@@ -1595,8 +1562,6 @@ def resolve_tools(value: ToolParam) -> Optional[ToolConfig]:
15951562
"resolve_reflection",
15961563
"resolve_guardrails",
15971564
"resolve_web",
1598-
"resolve_output",
1599-
"resolve_execution",
16001565
"resolve_caching",
16011566
"resolve_autonomy",
16021567
"resolve_tool_search",

0 commit comments

Comments
 (0)