Directory named 'go' in path results in EACCES error

[DonMcNamara]

In getBinPathFromEnvVar the code returns the first path that exists, regardless of permission. If that path is a directory named go and not an executable, the code will attempt to execute go version on the directory. This results in: error spawn eacces

Line of code in question: https://github.com/Microsoft/vscode-go/blob/master/src/goPath.ts#L24

Fix: I'm not too familiar with node, but checking the docs, I think this can be fixed by using the fs.accessSync method.

Workaround: Re-order your path, so the go executable is found before the directory.

[ramya-rao-a]

fs.accessSync would still not help in differentiating file vs directory. Will use fs.statSync instead
Here is a nice comparision: https://www.gregjs.com/javascript/2016/checking-whether-a-file-directory-exists-without-using-fs-exists/

[DonMcNamara]

Thank you!

[ramya-rao-a]

The latest update (0.6.48) has the fix.
Happy Coding!

[jeffprestes]

Sorry, I am still facing same issue to debug my application with Delve
I followed these steps: https://fresh-air.aerobatic.io/post/debug-golang/ but I am using a MAC
I gave +x permission to vscode directories and to my application directory and same issue.
Could you help me out to check where I should set the correct permission?

[ramya-rao-a]

@jeffmcaffer Can you share the complete error message you are seeing?
Also open the console (Developer: Toggle Developer Tools) and share any errors and call stack from there.

[jeffprestes]

@ramya-rao-a for sure.
Failed to continue: "Error: spawn EACCES"

messageService.ts:126 Failed to continue: "Error: spawn EACCES": Error: Failed to continue: "Error: spawn EACCES"
    at Object.g [as create] (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:30:20765)
    at file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:128:7799
    at Object.v [as _notify] (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:13263)
    at Object.enter (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:16768)
    at _run (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:18089)
    at _chainedError (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:17448)
    at n (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:15271)
    at then (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:18898)
    at Object.enter (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:15340)
    at _run (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:18089)
    at _setCompleteValue (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:17783)e.doShow @ messageService.ts:126e.show @ messageService.ts:105(anonymous function) @ compositePart.ts:284r @ eventEmitter.ts:314e._emitToSpecificTypeListeners @ eventEmitter.ts:182e._emitEvents @ eventEmitter.ts:201e.emit @ eventEmitter.ts:216(anonymous function) @ actions.ts:231v @ winjs.base.raw.js:1209enter @ winjs.base.raw.js:901_run @ winjs.base.raw.js:1068_chainedError @ winjs.base.raw.js:1031n @ winjs.base.raw.js:736then @ winjs.base.raw.js:1436enter @ winjs.base.raw.js:747_run @ winjs.base.raw.js:1068_setCompleteValue @ winjs.base.raw.js:1052v @ winjs.base.raw.js:1209enter @ winjs.base.raw.js:901_run @ winjs.base.raw.js:1068_chainedError @ winjs.base.raw.js:1031n @ winjs.base.raw.js:736then @ winjs.base.raw.js:1436enter @ winjs.base.raw.js:747_run @ winjs.base.raw.js:1068_setCompleteValue @ winjs.base.raw.js:1052v @ winjs.base.raw.js:1209enter @ winjs.base.raw.js:901_run @ winjs.base.raw.js:1068_error @ winjs.base.raw.js:1041(anonymous function) @ v8Protocol.ts:53e.dispatch @ v8Protocol.ts:136e.handleData @ v8Protocol.ts:104(anonymous function) @ v8Protocol.ts:41emitOne @ events.js:96emit @ events.js:188readableAddChunk @ _stream_readable.js:176Readable.push @ _stream_readable.js:134onread @ net.js:543
index.js:22 [uncaught exception]: Error: Unable to display threads: "Error: spawn EACCES"onError @ index.js:22(anonymous function) @ index.js:91emitOne @ events.js:96emit @ events.js:188window.onerror @ init.js:120i.globals.onerror @ errorTelemetry.ts:64
index.js:25 Error: Unable to display threads: "Error: spawn EACCES"
    at rawDebugSession.ts:181
    at Object.v [as _notify] (winjs.base.raw.js:1209)
    at Object.enter (winjs.base.raw.js:901)
    at _run (winjs.base.raw.js:1068)
    at _error (winjs.base.raw.js:1041)
    at v8Protocol.ts:53
    at _.e.dispatch (v8Protocol.ts:136)
    at _.e.handleData (v8Protocol.ts:104)
    at Socket.<anonymous> (v8Protocol.ts:41)
    at emitOne (events.js:96)
    at Socket.emit (events.js:188)onError @ index.js:25(anonymous function) @ index.js:91emitOne @ events.js:96emit @ events.js:188window.onerror @ init.js:120i.globals.onerror @ errorTelemetry.ts:64
rawDebugSession.ts:181 Uncaught Error: Unable to display threads: "Error: spawn EACCES"(anonymous function) @ rawDebugSession.ts:181v @ winjs.base.raw.js:1209enter @ winjs.base.raw.js:901_run @ winjs.base.raw.js:1068_error @ winjs.base.raw.js:1041(anonymous function) @ v8Protocol.ts:53e.dispatch @ v8Protocol.ts:136e.handleData @ v8Protocol.ts:104(anonymous function) @ v8Protocol.ts:41emitOne @ events.js:96emit @ events.js:188readableAddChunk @ _stream_readable.js:176Readable.push @ _stream_readable.js:134onread @ net.js:543
shell.ts:541 Unable to display threads: "Error: spawn EACCES": Error: Unable to display threads: "Error: spawn EACCES"
    at file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:90:21136
    at Object.v [as _notify] (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:13263)
    at Object.enter (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:16768)
    at _run (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:18089)
    at _error (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:17606)
    at file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:85:1178
    at _.e.dispatch (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:85:2523)
    at _.e.handleData (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:85:2035)
    at Socket.<anonymous> (file:////Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:85:1038)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)e.onUnexpectedError @ shell.ts:541(anonymous function) @ shell.ts:457e.onUnexpectedError @ errors.ts:68o @ errors.ts:88(anonymous function) @ winjs.base.js:43(anonymous function) @ winjs.base.js:38
winjs.base.js:45 WARNING: Promise with no error callback:185
winjs.base.js:46 Object {exception: null, error: Error: Unable to display threads: "Error: spawn EACCES"
    at file:////Applications/Visual Studio C…, promise: n.C…s.d…e.cancel, handler: undefined, id: 185…}

[ramya-rao-a]

Thanks @jeffprestes, and can you confirm that the rest of the Go extension features work for you?
Like Hover Info, Goto Definition, Find all references, Rename, Building, Linting, Formatting?

And is dlv working from the command line for you? This is to ensure that the dlv set up was correctly done.

cc @roblourens for thoughts on the callstack related to debugging

[jeffprestes]

Except for debug, coding Go using vscode in my machine is great! It's an amazing tool. We just need to fix this to become perfect!
dlv in command line is also running OK.

[ramya-rao-a]

The "Unable to display threads" is coming from https://github.com/Microsoft/vscode-go/blob/master/src/debugAdapter/goDebug.ts#L440 when try to get list of goroutines from delve.

@roblourens Is threadsRequest() one of the first things expected to run in the debug adapter?

@jeffprestes

Delve is failing to return the list of goroutines and giving the error EACCES error.

Are you able to execute the step and goroutines commands when running dlv debug in the command line?

Have you set go.goroot in your settings to anything that is different than the default by any chance?

[roblourens]

threadsRequest is sent only after hitting a breakpoint, which would imply that delve worked well enough to tell us that it hit a breakpoint. Not sure why that would happen.

[roblourens]

Actually if you have stopOnEntry enabled, it would be sent very early, do you?