This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Normalizes the program path that is stored in Delve object.#1131
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Aug 9, 2017
Merged
Normalizes the program path that is stored in Delve object.#1131ramya-rao-a merged 1 commit intomicrosoft:masterfrom
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
Conversation
The Delve this.program is compared against a normalizedPath in the this.toDebuggerPath() function and it needs to be noralized before this is done otherwise it will end up returning the wrong path for the remote file. This can be seen when running a Windows 10 64bit host trying to perform remote debugging to an Ubuntu server which requires a remote path. The non-normalized program path has a lower case for the drive letter returned in ("program": "${fileDirname}") and the normalized program path has a capital letter for the drive. This difference causes the replacement of the local directory path to fail, so the remotePath sent to the remote debugger is incorrect thus preventing break points from being set correctly.
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Contributor
|
Thanks for the fix @Craig-Stone! |
Contributor
|
This fix is now out in the latest update to the Go extension 0.6.64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Delve this.program is compared against a normalizedPath in the this.toDebuggerPath() function and it needs to be noralized before this is done otherwise it will end up returning the wrong path for the remote file. This can be seen when running a Windows 10 64bit host trying to perform remote debugging to an Ubuntu server which requires a remote path. The non-normalized program path has a lower case for the drive letter returned from the launch configuration ("program": "${fileDirname}") and the normalized program path has a capital letter for the drive. This difference causes the replacement of the local directory path to fail, so the remotePath sent to the remote debugger is incorrect thus preventing break points from being set correctly.