pass <package> to dlv test/debug if applicable

[zhouhaibing089]

we should prefer passing package name to dlv test or dlv debug. this fixes the issue mentioned at #846 (comment).

[ramya-rao-a]

@zhouhaibing089 Your issue in #846 (comment) is about running tests where as your PR here is in the debugging area. How will it help in fixing the issue of running tests?

[zhouhaibing089]

@ramya-rao-a the change in src/testUtils.ts is about the fix on running test.

[ramya-rao-a]

• this might not work in case of multiple GOPATHs, because then process.env['GOPATH'] can have : or ; separated paths. Follow https://github.com/Microsoft/vscode-go/blob/0.6.63/src/goCheck.ts#L180-L181 instead
• we are moving away from using GOPATH from process.env. Instead use getCurrentGoPath()
• When the command Go: Test All Packages In Workspace is run, this go test command will fail with "can't load package.. no buildable Go source files in ..." if the workspace itself is just a folder containing packages and not a package itself. So one way is to have the package import path as part of the TestConfig object

[zhouhaibing089]

PTAL again, I am not sure how the third item can be solved(and seems it is more than the effort here)

[ramya-rao-a]

testconfig.includeSubDirectories is true only for the "test all pks in workspace" scenario.
So you can add a check to ensure testconfig.includeSubDirectories is false before adding the importPath

[msftclas]

All CLA requirements met.

[ramya-rao-a]

@zhouhaibing089 One issue with passing the package to go test is that the log.Println or fmt.Println from the tests are no longer getting piped to stdout

@rakyll @francesc Would you know why go test would print out the log.Println and fmt.Println statements but go test import-path-to-my-package doesn't?

[zhouhaibing089]

go test -v import-path-to-my-package will do.

[zhouhaibing089]

If this is a regression issue, I propose that we add a configuration like: test.verbose, if it is true, we add the flag -v, otherwise suppress the output.

[rakyll]

go test and go test should be behave similarly, not outputting to stdout if -v is not set. Can you file an issue if that's not the case?

[ramya-rao-a]

Looks like its a platform issue

In Windows go test -v import-path-to-my-package prints the text from log.Println statements
But in Mac it doesn't. Both are using Go 1.9

Logged golang/go#22113

[ramya-rao-a]

Nope not a platform issue.
It was all me and my duplicate set up of the same project in the default GOPATH and my other GOPATH.

I was making the changes in one and go test package-path was testing the other.

All is well with the world folks, sorry for the churn