Complete method receivers of types in namespace #168#1368
Complete method receivers of types in namespace #168#1368ramya-rao-a merged 3 commits intomicrosoft:masterfrom
Conversation
|
|
ramya-rao-a
left a comment
ramya-rao-a
left a comment
There was a problem hiding this comment.
@grooveygr Nice work, I assumed I'd need list of all available types to provide this feature, but your way is so much more simpler and works perfectly :)
I have left 2 comments, let me know what you think of those.
src/goSuggest.ts
Outdated
| suggest.class === 'type' && !goBuiltinTypes.has(suggest.name)) { | ||
| let prefix = 'func (' + suggest.name[0].toLowerCase() + ' *' + suggest.name + ')'; | ||
| let auxItem = new vscode.CompletionItem(suggest.name + ' method', vscode.CompletionItemKind.Snippet); | ||
| auxItem.label = suggest.name + ' (new method)'; |
There was a problem hiding this comment.
What do you think of 'func (*' + suggest.name + ') for label and Method snippet for detail?
There was a problem hiding this comment.
I experimented with your idea and found that the vscode engine does not show suggestions in some cases where the suggest.name is not a prefix of the label. More specifically, when completing an unexported type the suggestion is not shown.
For now I changed the label to be exactly suggest.name and kept your suggestion for the label.
Let me know what you think!
There was a problem hiding this comment.
You can get around that by adding auxItem.filterText = suggest.name
By default the label is used for displaying the item as well as filtering the item based on what is typed. If filterText is set, then that will be used for filtering instead
There was a problem hiding this comment.
Nice! Learned something new.
Done.
src/goSuggest.ts
Outdated
| auxItem.label = suggest.name + ' (new method)'; | ||
| auxItem.detail = prefix + '...'; | ||
| auxItem.sortText = 'a'; | ||
| let snippet = prefix + ' ${1:name}(${2:params}) ${3:retval} \{\n\t$0\n\}'; |
There was a problem hiding this comment.
Since params and retval can be empty, why not have them as simple tabstops instead of placeholders?
i.e ${1:methodName}(${2}) ${3} instead of ${1:name}(${2:params}) ${3:retvall}
|
@grooveygr I had a question. Is it possible to have a method on a type from a different package? |
|
@ramya-rao-a according to the golang spec (https://golang.org/ref/spec#Method_declarations) adding methods to imported types is not supported.
When you try, you're met with a compilation error, e.g. |
|
Great, thanks for the clarification! |
3 participants
No description provided.