Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Switch to testfile if already open/visible instead of reopening#1517

Merged
ramya-rao-a merged 2 commits intomicrosoft:masterfrom
kwiesmueller:master
Feb 18, 2018
Merged

Switch to testfile if already open/visible instead of reopening#1517
ramya-rao-a merged 2 commits intomicrosoft:masterfrom
kwiesmueller:master

Conversation

@kwiesmueller
Copy link
Copy Markdown
Contributor

@kwiesmueller kwiesmueller commented Feb 14, 2018

Implementing the first feature mentioned in #610.
This PR prevents vscode from overriding the currently open file if the test is already open in another visible editor.
To improve this even further, this could benefit from microsoft/vscode#15178 to even open the file if it is not visible in the other open editors.

First PR here (even first contribution to vscode) so if something is not ok, please tell me :-)

@ramya-rao-a
Copy link
Copy Markdown
Contributor

Looks good, thanks @kwiesmueller!

@ramya-rao-a ramya-rao-a merged commit 25ad02b into microsoft:master Feb 18, 2018
@ramya-rao-a
Copy link
Copy Markdown
Contributor

This is now out in the latest update to the Go extension (0.6.77)
Thanks @kwiesmueller!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants