This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Fix the goVersion to properly parse ver '1.10'#1523
Merged
ramya-rao-a merged 10 commits intomicrosoft:masterfrom Feb 20, 2018
uudashr:master
Merged
Fix the goVersion to properly parse ver '1.10'#1523ramya-rao-a merged 10 commits intomicrosoft:masterfrom uudashr:master
ramya-rao-a merged 10 commits intomicrosoft:masterfrom
uudashr:master
Conversation
Contributor
Author
|
Use default CC and CXX fix the golang "tip" issue But somehow it failing on
@ramya-rao-a need help.. maybe you know the cause? |
Contributor
Author
|
Fix the lint test, the output has changed.. |
Contributor
Author
|
The output of the linter different for go version 1.10 vs prev version while prev version Not sure which one is correct. But fixed the test anyway |
Contributor
Author
|
@ramya-rao-a all good now... please check |
ramya-rao-a
approved these changes
Feb 20, 2018
Contributor
|
Thanks @uudashr! Sorry couldn't help you sooner, I was out all day. I'll look at releasing an update tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously go ver 1.10 parsed as "1.1"
Now fixed to as it should be "1.10"
This cause the "add import.." and "auto import unimported packages" broken