Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Fix the goVersion to properly parse ver '1.10'#1523

Merged
ramya-rao-a merged 10 commits intomicrosoft:masterfrom
uudashr:master
Feb 20, 2018
Merged

Fix the goVersion to properly parse ver '1.10'#1523
ramya-rao-a merged 10 commits intomicrosoft:masterfrom
uudashr:master

Conversation

@uudashr
Copy link
Copy Markdown
Contributor

@uudashr uudashr commented Feb 19, 2018

Previously go ver 1.10 parsed as "1.1"
Now fixed to as it should be "1.10"

This cause the "add import.." and "auto import unimported packages" broken

@uudashr uudashr closed this Feb 19, 2018
@uudashr uudashr reopened this Feb 19, 2018
@uudashr uudashr closed this Feb 19, 2018
@uudashr uudashr reopened this Feb 19, 2018
@uudashr uudashr closed this Feb 19, 2018
@uudashr uudashr reopened this Feb 19, 2018
@uudashr uudashr closed this Feb 19, 2018
@uudashr uudashr reopened this Feb 19, 2018
@uudashr
Copy link
Copy Markdown
Contributor Author

uudashr commented Feb 19, 2018

Use default CC and CXX fix the golang "tip" issue

But somehow it failing on

  1. Test Linter for Package
  2. Fill struct – select non-struct line

@ramya-rao-a need help.. maybe you know the cause?

@uudashr uudashr closed this Feb 19, 2018
@uudashr uudashr reopened this Feb 19, 2018
@uudashr
Copy link
Copy Markdown
Contributor Author

uudashr commented Feb 19, 2018

Fix the lint test, the output has changed..

> gometalinter --disable-all --enable=golint --enable=errcheck .
linter_1.go:5:1:warning: exported function ExportedFunc should have comment or be unexported (golint)
linter_1.go:8:3:warning: error return value not checked (a declared but not used) (errcheck)
linter_2.go:5:1:warning: error return value not checked (missing return) (errcheck)

@uudashr uudashr closed this Feb 19, 2018
@uudashr uudashr reopened this Feb 19, 2018
@uudashr
Copy link
Copy Markdown
Contributor Author

uudashr commented Feb 19, 2018

The output of the linter different for go version 1.10 vs prev version
go 1.10

linter_1.go:8:3:warning: error return value not checked (a declared but not used) (errcheck)

while prev version

linter_1.go:8:3:warning: error return value not checked (a declared but not used) (errcheck, errcheck)

Not sure which one is correct. But fixed the test anyway

@uudashr
Copy link
Copy Markdown
Contributor Author

uudashr commented Feb 19, 2018

@ramya-rao-a all good now... please check

@ramya-rao-a
Copy link
Copy Markdown
Contributor

Thanks @uudashr!

Sorry couldn't help you sooner, I was out all day.

I'll look at releasing an update tomorrow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants