This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Merged
Conversation
Member
Author
|
The failures look unrelated |
Contributor
|
About the failures... The ones for Go 1.5 is because The others are just linting errors, should be easy to fix |
ramya-rao-a
approved these changes
Oct 25, 2016
Member
Author
|
Didn't notice the lint, fixed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #552.
This is copied from node-debug/node-debug2. It doesn't check whether a port is already in use, but... there are lots of ports out there. Without this, debugging two Go processes with a 'composite' launch config won't work out of the box without specifying ports manually.