This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Dont generate unit tests for non Go files#584
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Oct 31, 2016
Merged
Conversation
roblourens
approved these changes
Oct 31, 2016
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
I also noticed that gotests won't generate tests if the test files already exist, and it will write a message to stdout saying that. But vscode-go will still show the success message. Maybe can just show gotests's output in the future.
| return; | ||
| } | ||
| if (!editor.document.fileName.endsWith('.go')) { | ||
| vscode.window.showInformationMessage('Cannot generate unit tests. File in the editor is not a Go file.'); |
Member
There was a problem hiding this comment.
Is there definitely no case where a go file can have some other extension?
Member
There was a problem hiding this comment.
Yeah I searched around and couldn't find any
Contributor
Author
|
@roblourens #566 is tracking your #584 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563