Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Open test file after the Generate Unit Tests command#610

Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
ramya-rao-a:test-jump
Nov 9, 2016
Merged

Open test file after the Generate Unit Tests command#610
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
ramya-rao-a:test-jump

Conversation

@ramya-rao-a
Copy link
Copy Markdown
Contributor

@ramya-rao-a ramya-rao-a commented Nov 9, 2016

@ramya-rao-a ramya-rao-a merged commit c23c83c into microsoft:master Nov 9, 2016
@ramya-rao-a ramya-rao-a deleted the test-jump branch January 22, 2017 07:58
@kwiesmueller
Copy link
Copy Markdown
Contributor

As I keep being annoyed by this feature in my daily work I was looking for a setting to disable it. As there is none I want to ask here.
When I work with tests in go, most of the time I got my editor in split. Left is code, right is test.
When then using the add test feature, my code gets closed and the test file (i already have open) gets opened there.
This is gets kinda annoying when generating a lot of tests.
My suggestion would be a setting for this to enable or disable it.
As an addition to that, I would also appreciate a setting to disable the "test created" modal, which blocks my view every time even if I don't care about.

What do you think?

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Feb 5, 2018

For the opening of test file after generating tests, we can add a check so that it doesn't happen if the test file is already open.
For the notification, instead of a setting we can have a "Don't show again" option. We have too many settings already in the extension and I'd like to avoid adding a new one :)

PR for both these improvements are welcome

@kwiesmueller
Copy link
Copy Markdown
Contributor

Sounds good to me.
I already disabled the opening of tests locally, so I might as well do this as a pr with your suggestion.

kwiesmueller pushed a commit to kwiesmueller/vscode-go that referenced this pull request Feb 14, 2018
ramya-rao-a pushed a commit that referenced this pull request Feb 18, 2018
* Switch to testfile if already open/visible instead of reopening

cc #610

* Fix syntax error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants