This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Do not get definition info if not identifier#711
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Jan 5, 2017
Merged
Do not get definition info if not identifier#711ramya-rao-a merged 1 commit intomicrosoft:masterfrom
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
Conversation
roblourens
approved these changes
Jan 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go extension spawns a new process to get definition information each time the hover provider is triggered. This sometimes results in massive number of processes to spin up and cause perf issues.
When we know beforehand that the text under the cursor is not an identifier, then we can skip creating new processes to get definition information.
In this PR, we do this for the below cases: