This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Improve error handling of test coverage#721
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Jan 13, 2017
Merged
Conversation
|
Hi @nochso, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Contributor
|
@nochso You have linting errors that is breaking the build. Can you fix them? |
- The previous condition did not catch any errors when `go test` for retrieving coverage failed. - Use an output channel to show the error message. showInformationMessage is only good for single lines. Fixes microsoft#350
nochso
force-pushed
the
coverage-error
branch
from
f08a0ae to
a48ef2f
Compare
Contributor
Author
|
@ramya-rao-a I've fixed the linting errors and squashed the commit. |
ramya-rao-a
approved these changes
Jan 13, 2017
Contributor
|
Thanks @nochso |
mattetti
added a commit
to mattetti/vscode-go
that referenced
this pull request
Jan 16, 2017
…ild-i * 'master' of github.com:Microsoft/vscode-go: Moved debugging doc to a separate wiki Make a copy of process.env when setting VSCODE_GOTOOLS Debugger cannot read settings Improve error handling of test coverage (microsoft#721) Use proper plurality in output (microsoft#720) Fixes microsoft#303 Dont run test if current file is not test file Added a note on how to debug single tests Allow Go tools to be installed in a separate GOPATH (microsoft#351) Fix typo in README.md (microsoft#715) Honor the 'cwd' launch configuration argument (microsoft#714)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go testfor retrieving coverage failed.Fixes #350