This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Use GOPATH from env if dlv not found#725
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Jan 19, 2017
Merged
Conversation
tw1nk
reviewed
Jan 17, 2017
src/debugAdapter/goDebug.ts
Outdated
| if (!existsSync(dlv) && env['GOPATH'] && !process.env['GOPATH']) { | ||
| process.env['GOPATH'] = env['GOPATH']; | ||
| dlv = getBinPath('dlv'); | ||
| process.env['GOPATH'] = undefined; |
There was a problem hiding this comment.
Wouldn't it be nicer if the getBinPath took an (optional) second argument called gopath and used that instead of changing the process.env['GOPATH']?
Contributor
Author
There was a problem hiding this comment.
good point, I like it :)
ramya-rao-a
force-pushed
the
debug-use-env-gopath
branch
from
d8802a6 to
40beca5
Compare
Contributor
Author
|
@tw1nk Updated as per your suggestion. I agree, its much cleaner this way. Thanks! |
roblourens
approved these changes
Jan 17, 2017
|
|
Contributor
Author
|
Thanks @guogeer, I found this the other day too. The fix is already in master. The next update of the Go extension will have the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.