This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Use settings for separate location for installing Go tools#737
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Jan 21, 2017
Merged
Use settings for separate location for installing Go tools#737ramya-rao-a merged 1 commit intomicrosoft:masterfrom
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
Conversation
roblourens
approved these changes
Jan 21, 2017
| "gogetdoc" | ||
| ] | ||
| }, | ||
| "go.toolsGopath": { |
Member
There was a problem hiding this comment.
Or maybe gopath is like one word, either way
Contributor
Author
There was a problem hiding this comment.
I feel different everytime I think about it :(
ramya-rao-a
force-pushed
the
separate-gotools-path
branch
from
8cce7d1 to
3af5413
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5 for the discussion on the need for a separate location to install Go tools instead of the user's GOPATH.
See #351 for the implementation using env vars and further talk of how a VS Code setting is better instead of env var
This PR is to use VS Code setting where user can provide a location for installing the Go tools.
gometalinteris an exception to this rule and will get installed in the user's GOPATH always.This is because
gometalinterexpects all the linters it uses to be in the user's GOPATH.Users need to install
dlvmanually as always and is out of this disucssioncc @roblourens