This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Map unexpected errors to first line#740
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Jan 24, 2017
Merged
Conversation
roblourens
approved these changes
Jan 24, 2017
src/goCheck.ts
Outdated
| ret.push({ | ||
| file: vscode.window.activeTextEditor.document.fileName, | ||
| line: 1, | ||
| msg: 'Something went wrong. Check the Go channel in the output window', |
Member
There was a problem hiding this comment.
Can we not show the actual messages, 'can't load package: import cycle not allowed' etc?
Contributor
Author
There was a problem hiding this comment.
Good point. Done.
Member
There was a problem hiding this comment.
Oh man I did that thing again where I typed that this morning before standup but didn't submit the review. Just had to say that since we talked about this at standup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664
cc @roblourens