This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Changed the default go.testFlags to not include -v option#817
Merged
ramya-rao-a merged 2 commits intomicrosoft:masterfrom Feb 24, 2017
jeffwillette:master
Merged
Changed the default go.testFlags to not include -v option#817ramya-rao-a merged 2 commits intomicrosoft:masterfrom jeffwillette:master
ramya-rao-a merged 2 commits intomicrosoft:masterfrom
jeffwillette:master
Conversation
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
ramya-rao-a
reviewed
Feb 24, 2017
src/goTest.ts
Outdated
|
|
||
| function getTestFlags(goConfig: vscode.WorkspaceConfiguration, args: any): string[] { | ||
| let testFlags = goConfig['testFlags'] ? goConfig['testFlags'] : ['-v', ...goConfig['buildFlags']]; | ||
| let testFlags = goConfig['testFlags'] ? goConfig['testFlags'] : [goConfig['buildFlags']]; |
Contributor
There was a problem hiding this comment.
you don't need the [] around goConfig['buildFlags'] I believe
ramya-rao-a
suggested changes
Feb 24, 2017
Contributor
ramya-rao-a
left a comment
ramya-rao-a
left a comment
There was a problem hiding this comment.
you don't need the extra []
Contributor
Author
|
@ramya-rao-a ...done |
ramya-rao-a
approved these changes
Feb 24, 2017
Contributor
|
Thanks @deltaskelta ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.