This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Fixes #846 Use import path instead of .#864
Merged
ramya-rao-a merged 3 commits intomicrosoft:masterfrom Mar 16, 2017
Merged
Conversation
roblourens
approved these changes
Mar 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out
.is resolved differently when a go command is run from the command line vs from a new process in case of symlinks.Which is why
go build .works in the command line but not in VS Code for projects in symlinked foldersIn this PR we use the import path instead of
.to prevent any resolution to be attempted by the Go tool