showCovered/showUncovered#945
Conversation
|
@kode4food, It will cover your contributions to all Microsoft-managed open source projects. |
|
@kode4food, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
The one failing build configuration seems to be completely unrelated to the PR |
|
@kode4food, |
package.json
Outdated
| "default": false, | ||
| "description": "Run 'go test -coverprofile' on save" | ||
| }, | ||
| "go.showCovered": { |
There was a problem hiding this comment.
Am a little hesitant to add new settings. The list of settings we have is really blowing up.
How about re-using the existing setting for coverage.
"go.coverOnSave": {
"type": ["boolean", "string"],
"enum": [true, "showCoveredOnly", "showUncoveredOnly"],
"default": true,
"description": "..."
}
There was a problem hiding this comment.
@ramya-rao-a Just as well! I won't be able to get around to it until Friday though
There was a problem hiding this comment.
no problem, I am planning to release an update early next week. So Friday sounds good.
There was a problem hiding this comment.
I lied, just pushed the changes
|
@kode4food, |
ramya-rao-a
left a comment
ramya-rao-a
left a comment
There was a problem hiding this comment.
Great, the description of the setting needs an update, I'll take care of that
|
@kode4food Since we have the See 9ddd218 |
3 participants
Adding two configuration options:
go.showCovered(defaults to true) will decorate covered code in greengo.showUncovered(defaults to true) will decorate uncovered code in red