fix: Use same default keystore values as Morphe Manager#96
Merged
Conversation
LisoUseInAIKyrios
changed the title
Contributor
|
This breaks compatibility for users with existing key stores. What to do? |
Contributor
Author
|
The cli could try the new defaults and if that fails, it can try the old defaults. |
Contributor
Author
|
Try this once. Worked in my testing, but test it just in case. |
LisoUseInAIKyrios
left a comment
LisoUseInAIKyrios
left a comment
Contributor
There was a problem hiding this comment.
Code here works for me. Old signing key alias/password is used.
Contributor
Author
|
Is this better? I could maybe move the constants inside the Config data class for PatchEngine no? What would be the best practice here? |
Contributor
Author
|
How about now? |
Contributor
Author
|
@LisoUseInAIKyrios Unrelated to this: I have been working on a gui-overhaul branch that was branched off the original gui branch that you had merged about 2 weeks ago. I assumed it would stay on the track with dev. But I did not realize how much it had diverged from dev until I tried merging. I tried to see how the merge would go and there are about 40+ conflicts. In some places, dev is ahead and in other places, I need to keep my changes. Worst of all, some files need to have stuff from both the branches in different places. It's basically hell. What is the best way to solve this? |
Contributor
|
Open a draft PR and we can try to fix the merge conflicts together. |
LisoUseInAIKyrios
force-pushed
the
align-keystore
branch
from
026843f to
48e824a
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
## [1.6.4-dev.2](v1.6.4-dev.1...v1.6.4-dev.2) (2026-03-31) ### Bug Fixes * Use same default keystore values as Morphe Manager ([#96](#96)) ([2d70c01](2d70c01))
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
# [1.7.0](v1.6.3...v1.7.0) (2026-04-16) ### Bug Fixes * Use patcher implementation of strip libs ([#83](#83)) ([43f50ea](43f50ea)), closes [#80](#80) [#82](#82) * Use same default keystore values as Morphe Manager ([#96](#96)) ([2d70c01](2d70c01)) ### Features * Add GUI third party patch sources, add experimental app patching ([#98](#98)) ([da5ec1c](da5ec1c))
2 tasks
AzyrRuthless
pushed a commit
to AzyrRuthless/morphe-cli
that referenced
this pull request
Apr 21, 2026
github-actions Bot
pushed a commit
to AzyrRuthless/morphe-cli
that referenced
this pull request
Apr 22, 2026
# [1.5.0-dev.1](v1.4.1...v1.5.0-dev.1) (2026-04-22) ### Bug Fixes * Use patcher implementation of strip libs ([MorpheApp#83](https://github.com/AzyrRuthless/morphe-cli/issues/83)) ([206fd70](206fd70)), closes [MorpheApp#80](https://github.com/AzyrRuthless/morphe-cli/issues/80) [MorpheApp#82](https://github.com/AzyrRuthless/morphe-cli/issues/82) * Use same default keystore values as Morphe Manager ([MorpheApp#96](https://github.com/AzyrRuthless/morphe-cli/issues/96)) ([0603a6d](0603a6d)) ### Features * Add GUI third party patch sources, add experimental app patching ([MorpheApp#98](https://github.com/AzyrRuthless/morphe-cli/issues/98)) ([a611751](a611751))
github-actions Bot
pushed a commit
to AzyrRuthless/morphe-cli
that referenced
this pull request
Apr 22, 2026
# [1.5.0](v1.4.1...v1.5.0) (2026-04-22) ### Bug Fixes * Use patcher implementation of strip libs ([MorpheApp#83](https://github.com/AzyrRuthless/morphe-cli/issues/83)) ([206fd70](206fd70)), closes [MorpheApp#80](https://github.com/AzyrRuthless/morphe-cli/issues/80) [MorpheApp#82](https://github.com/AzyrRuthless/morphe-cli/issues/82) * Use same default keystore values as Morphe Manager ([MorpheApp#96](https://github.com/AzyrRuthless/morphe-cli/issues/96)) ([0603a6d](0603a6d)) ### Features * Add GUI third party patch sources, add experimental app patching ([MorpheApp#98](https://github.com/AzyrRuthless/morphe-cli/issues/98)) ([a611751](a611751))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both keyStoreEntryAlias and keyStoreEntryPassword are now set to "Morphe", which is the default in the manager too.