fix: Cancelled install callbacks on some OEM systems (#598)

Co-authored-by: MarcaDian <152095496+MarcaDian@users.noreply.github.com>

Author: zjns

app/src/main/java/app/morphe/manager/ui/viewmodel/InstallViewModel.kt

@@ -17,6 +17,7 @@ import app.morphe.manager.domain.installer.*
 import app.morphe.manager.domain.manager.PreferencesManager
 import app.morphe.manager.util.AppDataResolver
 import app.morphe.manager.util.PM
+import app.morphe.manager.util.sha256OrNull
 import app.morphe.manager.util.simpleMessage
 import app.morphe.manager.util.toast
 import kotlinx.coroutines.*
@@ -374,9 +375,14 @@ class InstallViewModel : ViewModel(), KoinComponent {
         val result = try {
             sessionInstaller.installInternal(outputFile)
         } catch (_: InstallCancelledException) {
-            // User dismissed the dialog - go back to Ready immediately, no error shown
-            installState = InstallState.Ready
-            return
+            if (confirmInstallCompleted(outputFile, targetPackageName)) {
+                Log.w(TAG, "Install callback reported cancelled but APK SHA-256 verification succeeded for $targetPackageName")
+                InstallResult.Success
+            } else {
+                // User dismissed the dialog and the installed APK does not match the patched APK.
+                installState = InstallState.Ready
+                return
+            }
         } catch (_: SessionDeadException) {
             Log.w(TAG, "Session dead, falling back to intent-based install")
             launchIntentBasedFallback(outputFile, targetPackageName, onPersistApp)
@@ -398,6 +404,18 @@ class InstallViewModel : ViewModel(), KoinComponent {
         }
     }
 
+    private suspend fun confirmInstallCompleted(
+        outputFile: File,
+        targetPackageName: String
+    ): Boolean = withContext(Dispatchers.IO) {
+        val installedFile = pm.getApplicationInfo(targetPackageName)?.sourceDir
+            ?.takeIf { it.isNotEmpty() }
+            ?.let(::File) ?: return@withContext false
+        val installedHash = installedFile.sha256OrNull() ?: return@withContext false
+        val expectedHash = outputFile.sha256OrNull() ?: return@withContext false
+        installedHash == expectedHash
+    }
+
     /**
      * Silent install via Shizuku/Sui.
      */

app/src/main/java/app/morphe/manager/util/PM.kt

@@ -4,8 +4,10 @@ import android.annotation.SuppressLint
 import android.app.Application
 import android.content.Context
 import android.content.Intent
+import android.content.pm.ApplicationInfo
 import android.content.pm.PackageInfo
 import android.content.pm.PackageManager
+import android.content.pm.PackageManager.ApplicationInfoFlags
 import android.content.pm.PackageManager.NameNotFoundException
 import android.content.pm.PackageManager.PackageInfoFlags
 import android.content.pm.Signature
@@ -41,6 +43,7 @@ class PM(
 
     val application: Application get() = app
 
+    @Suppress("DEPRECATION")
     fun getPackageInfo(packageName: String, flags: Int = 0): PackageInfo? =
         try {
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU)
@@ -51,6 +54,17 @@ class PM(
             null
         }
 
+    @Suppress("DEPRECATION")
+    fun getApplicationInfo(packageName: String, flags: Int = 0): ApplicationInfo? =
+        try {
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU)
+                app.packageManager.getApplicationInfo(packageName, ApplicationInfoFlags.of(flags.toLong()))
+            else
+                app.packageManager.getApplicationInfo(packageName, flags)
+        } catch (_: NameNotFoundException) {
+            null
+        }
+
     fun getPackageInfo(file: File): PackageInfo? {
         val path = file.absolutePath
         val flags = PackageManager.GET_META_DATA or PackageManager.GET_ACTIVITIES
@@ -212,6 +226,21 @@ class PM(
     }
 }
 
+fun File.sha256OrNull(): String? = runCatching {
+    if (!isFile) return@runCatching null
+    val digest = MessageDigest.getInstance("SHA-256")
+    inputStream().use { input ->
+        val buffer = ByteArray(DEFAULT_BUFFER_SIZE)
+        while (!Thread.currentThread().isInterrupted) {
+            val read = input.read(buffer)
+            if (read < 0) break
+            digest.update(buffer, 0, read)
+        }
+    }
+    if (Thread.currentThread().isInterrupted) return@runCatching null
+    digest.digest().joinToString("") { byte -> "%02x".format(byte) }
+}.getOrNull()
+
 /** Opens the system screen that lets the user grant the "install unknown apps" permission. */
 object RequestInstallAppsContract : ActivityResultContract<String, Boolean>(), KoinComponent {
     private val pm: PM by inject()