STREAM-599: fix codacy recs

Author: Aidan Zimmermann

react-demo-app/src/components/AudioDevices.tsx

@@ -30,7 +30,7 @@ export default function AudioDevices() {
             }
           >
             <GuxListbox>
-              {deviceState.audioDevices.map((device: any) => (
+              {deviceState.audioDevices.map((device: MediaDeviceInfo) => (
                 <GuxOption key={device.deviceId} value={device.deviceId}>
                   {device.label}
                 </GuxOption>

react-demo-app/src/components/HandledPendingSessionsTable.tsx

@@ -2,6 +2,7 @@ import { GuxTable } from 'genesys-spark-components-react';
 import { useSelector } from 'react-redux';
 import Card from './Card';
 import { RootState } from '../types/store';
+import { IPendingSession } from 'genesys-cloud-webrtc-sdk';
 
 export default function HandledPendingSessionsTable() {
   const handledPendingSessions = useSelector(
@@ -23,7 +24,7 @@ export default function HandledPendingSessionsTable() {
               </tr>
             </thead>
             <tbody>
-              {handledPendingSessions.map((convo: any) => (
+              {handledPendingSessions.map((convo: IPendingSession) => (
                 <tr key={convo.conversationId}>
                   <td>{convo.conversationId}</td>
                   <td>{convo.sessionId}</td>

react-demo-app/src/components/OutputDevices.tsx

@@ -20,7 +20,7 @@ export default function OutputDevices() {
             }
           >
             <GuxListbox>
-              {deviceState.outputDevices.map((device: any) => (
+              {deviceState.outputDevices.map((device: MediaDeviceInfo) => (
                 <GuxOption key={device.deviceId} value={device.deviceId}>
                   {device.label}
                 </GuxOption>

react-demo-app/src/components/PendingSessionsTable.tsx

@@ -3,6 +3,7 @@ import { GuxTable, GuxButton } from 'genesys-spark-components-react';
 import { useSelector } from 'react-redux';
 import Card from './Card';
 import { RootState } from '../types/store';
+import { IPendingSession } from 'genesys-cloud-webrtc-sdk';
 
 export default function PendingSessionsTable() {
   const conversations = useSelector(
@@ -41,7 +42,7 @@ export default function PendingSessionsTable() {
               </tr>
             </thead>
             <tbody>
-              {conversations.map((convo: any) => (
+              {conversations.map((convo: IPendingSession) => (
                 <tr key={convo.conversationId}>
                   <td>{convo.conversationId}</td>
                   <td>{convo.sessionId}</td>

react-demo-app/src/components/VideoDevices.tsx

@@ -18,7 +18,7 @@ export default function VideoDevices() {
           }
         >
           <GuxListbox>
-            {deviceState.videoDevices.map((device: any) => (
+            {deviceState.videoDevices.map((device: MediaDeviceInfo) => (
               <GuxOption key={device.deviceId} value={device.deviceId}>
                 {device.label}
               </GuxOption>

react-demo-app/src/features/sdkSlice.ts

@@ -1,7 +1,8 @@
 import { createSlice, PayloadAction } from '@reduxjs/toolkit';
+import { MinimalSdk } from '../types/sdk';
 
 interface SdkState {
-  sdk: any;
+  sdk: MinimalSdk | null;
 }
 
 const initialState: SdkState = {
@@ -12,7 +13,7 @@ export const sdkSlice = createSlice({
   name: 'sdk',
   initialState: initialState,
   reducers: {
-    setSdk: (state, action: PayloadAction<any>) => {
+    setSdk: (state, action: PayloadAction<MinimalSdk>) => {
       state.sdk = action.payload;
     }
   }

react-demo-app/src/hooks/useSdk.ts

@@ -5,7 +5,8 @@ import {
   SessionTypes,
   ISessionIdAndConversationId,
   SdkMediaStateWithType,
-  ISdkGumRequest
+  ISdkGumRequest,
+  IExtendedMediaSession
 } from 'genesys-cloud-webrtc-sdk';
 import { v4 } from 'uuid';
 import { useDispatch } from 'react-redux';
@@ -20,6 +21,7 @@ import { updateGumRequests, updateMediaState } from '../features/devicesSlice';
 import { useSelector } from 'react-redux';
 import { IPendingSession } from 'genesys-cloud-streaming-client';
 import { RootState } from '../types/store';
+import { MinimalSdk } from '../types/sdk';
 
 interface IAuthData {
   token: string;
@@ -46,7 +48,7 @@ export default function useSdk() {
     };
 
     webrtcSdk = new GenesysCloudWebrtcSdk(options);
-    dispatch(setSdk(webrtcSdk));
+    dispatch(setSdk(webrtcSdk as MinimalSdk));
 
     connectEventHandlers();
 
@@ -129,7 +131,7 @@ export default function useSdk() {
     dispatch(updateGumRequests());
   }
 
-  function updateDefaultDevices(options: any): void {
+  function updateDefaultDevices(options: { audioDeviceId?: string; videoDeviceId?: string; outputDeviceId?: string }): void {
     if (!sdk) return;
     sdk.updateDefaultDevices({
       ...options,
@@ -156,18 +158,19 @@ export default function useSdk() {
 
   /* Misc Functions */
   async function updateOnQueueStatus(onQueue: boolean): Promise<void> {
-    if (!sdk) return;
+    if (!sdk || !sdk._http || !sdk._config || !sdk._personDetails) return;
     const systemPresences = await sdk._http.requestApi(`systempresences`, {
       method: 'get' as const,
       host: sdk._config.environment || '',
       authToken: sdk._config.accessToken
     });
 
     let presenceDefinition;
+    const presences = systemPresences.data as Array<{ name: string }>;
     if (onQueue) {
-      presenceDefinition = systemPresences.data.find((p: { name: string; }) => p.name === 'ON_QUEUE')
+      presenceDefinition = presences.find((p: { name: string; }) => p.name === 'ON_QUEUE')
     } else {
-      presenceDefinition = systemPresences.data.find((p: { name: string; }) => p.name === 'AVAILABLE')
+      presenceDefinition = presences.find((p: { name: string; }) => p.name === 'AVAILABLE')
     }
     const requestOptions = {
       method: 'patch' as const,
@@ -181,8 +184,8 @@ export default function useSdk() {
 
   function disconnectPersistentConnection(): void {
     if (!sdk) return;
-    const sessions = sdk.sessionManager.getAllActiveSessions().filter((session: any) => session.sessionType === SessionTypes.softphone);
-    sessions.forEach((session: any) => sdk.forceTerminateSession(session.id));
+    const sessions = sdk.sessionManager.getAllActiveSessions().filter((session: IExtendedMediaSession) => session.sessionType === SessionTypes.softphone);
+    sessions.forEach((session: IExtendedMediaSession) => sdk.forceTerminateSession(session.id));
   }
 
   return {

react-demo-app/src/types/sdk.ts

@@ -0,0 +1,44 @@
+// Minimal SDK interface for type safety
+import { IExtendedMediaSession } from 'genesys-cloud-webrtc-sdk';
+export interface MinimalSdk {
+  startSoftphoneSession: (params: { phoneNumber: string }) => void;
+  endSession: (params: { conversationId: string }) => void;
+  setAudioMute: (params: { mute: boolean; conversationId: string }) => Promise<void>;
+  setConversationHeld: (params: { held: boolean; conversationId: string }) => Promise<void>;
+  updateDefaultDevices: (options: { audioDeviceId?: string; videoDeviceId?: string; outputDeviceId?: string; updateActiveSessions?: boolean }) => void;
+  updateAudioVolume: (volume: number) => void;
+  destroy: () => Promise<void>;
+  acceptPendingSession: (params: { conversationId: string }) => void;
+  rejectPendingSession: (params: { conversationId: string }) => void;
+  forceTerminateSession: (sessionId: string) => void;
+  media: {
+    enumerateDevices: (force?: boolean) => void;
+    requestMediaPermissions: (type: 'audio' | 'video' | 'both') => void;
+  };
+  sessionManager: {
+    getAllActiveSessions: () => IExtendedMediaSession[];
+  };
+  station?: {
+    webRtcPersistentEnabled?: boolean;
+    name?: string;
+    id?: string;
+    status?: string;
+    type?: string;
+    webRtcCallAppearances?: number;
+    webRtcForceTurn?: boolean;
+    [key: string]: unknown;
+  } | null;
+  _config?: {
+    environment?: string;
+    accessToken?: string;
+    defaults?: {
+      audioVolume?: number;
+    };
+  };
+  _http?: {
+    requestApi: (endpoint: string, options: { method: 'get' | 'post' | 'patch' | 'put' | 'delete'; host: string; authToken?: string; data?: string }) => Promise<{ data: unknown }>;
+  };
+  _personDetails?: {
+    id: string;
+  };
+}