[STREAM-151] Use a proper communicationId

Author: hjon

src/stats-aggregator.ts

@@ -1,7 +1,7 @@
 import StatsGatherer, { GetStatsEvent, StatsEvent } from "webrtc-stats-gatherer";
 import { v4 as uuidv4 } from "uuid";
 
-import GenesysCloudWebrtSdk, { IExtendedMediaSession } from ".";
+import GenesysCloudWebrtSdk, { IConversationParticipantFromEvent, IExtendedMediaSession } from ".";
 import { requestApi } from "./utils";
 
 interface ISentStats {
@@ -28,6 +28,8 @@ export class StatsAggregator {
   }
 
   private handleStatsUpdate (stats: StatsEvent) {
+
+
     // We want the time to be as close to the cretion of the stats as possible, even
     // though we may throw this away in some cases.
     const dateCreated = new Date();
@@ -102,8 +104,22 @@ export class StatsAggregator {
   }
 
   private sendStats (rtpStats: ISentStats, dateCreated: Date) {
+    // Not sure if this is where I want to do this yet, but I'm sketching
+    const pcParticipant = this.session.pcParticipant;
+    console.log('Hjon: This is the pcParticpant: ', pcParticipant);
+    if (!pcParticipant) {
+      console.warn('Hjon: no pcParticipant');
+      return;
+    }
+    const calls = pcParticipant['calls'] ?? [];
+    if (calls.length === 0) {
+      console.warn('Hjon: I\'m wrong, no calls exist on this pcParticipant');
+      return;
+    }
+    const participant = pcParticipant as unknown as IConversationParticipantFromEvent;
+    const communicationId = participant.calls[0].id;
+
     const conversationId = this.session.conversationId;
-    const communicationId = "hjon-test-data";
 
     const {
       originAppId,

test/unit/stats-aggregator.test.ts

@@ -1,6 +1,5 @@
 import GenesysCloudWebrtSdk, { IExtendedMediaSession, utils } from "../../src";
 import { StatsAggregator } from "../../src/stats-aggregator"
-import { requestApiWithRetry } from "../../src/utils";
 import { MockSession, SimpleMockSdk } from "../test-utils";
 
 describe('StatsAggregator', () => {
@@ -160,6 +159,10 @@ describe('StatsAggregator', () => {
   });
 
   describe('sendStats', () => {
+    afterEach(() => {
+      jest.restoreAllMocks();
+    });
+
     it('should call requestApi', () => {
       const requestApiSpy = jest.spyOn(utils, 'requestApi').mockResolvedValue(null);
       const mockSession = new MockSession() as unknown as IExtendedMediaSession;
@@ -171,6 +174,10 @@ describe('StatsAggregator', () => {
         averageJitter: 0.1,
         estimatedAverageMos: 5
       }
+      const participant = {
+        calls: [{ id: "testCall" }]
+      };
+      mockSession.pcParticipant = participant as any;
 
       statsAggregator['sendStats'](rtpStats, new Date());
 
@@ -185,5 +192,49 @@ describe('StatsAggregator', () => {
       // This should actually check it
       expect(statsArgument['dateCreated']).toBeTruthy();
     });
+
+    it('should not call requestApi if there is no participant', () => {
+      const requestApiSpy = jest.spyOn(utils, 'requestApi').mockResolvedValue(null);
+      const mockSession = new MockSession() as unknown as IExtendedMediaSession;
+      const sdk = new SimpleMockSdk() as unknown as GenesysCloudWebrtSdk;
+      const statsAggregator = new StatsAggregator(mockSession, sdk);
+      const rtpStats = {
+        packetsReceived: 5,
+        packetsSent: 5,
+        averageJitter: 0.1,
+        estimatedAverageMos: 5
+      }
+
+      statsAggregator['sendStats'](rtpStats, new Date());
+
+      expect(requestApiSpy).not.toHaveBeenCalled();
+    });
+
+    it('should not call requestApi if there are no calls for the participant', () => {
+      const requestApiSpy = jest.spyOn(utils, 'requestApi').mockResolvedValue(null);
+      const mockSession = new MockSession() as unknown as IExtendedMediaSession;
+      const sdk = new SimpleMockSdk() as unknown as GenesysCloudWebrtSdk;
+      const statsAggregator = new StatsAggregator(mockSession, sdk);
+      const rtpStats = {
+        packetsReceived: 5,
+        packetsSent: 5,
+        averageJitter: 0.1,
+        estimatedAverageMos: 5
+      }
+
+      const participantA = {
+        calls: []
+      };
+      mockSession.pcParticipant = participantA as any;
+      statsAggregator['sendStats'](rtpStats, new Date());
+
+      expect(requestApiSpy).not.toHaveBeenCalled();
+
+      const participantB = {};
+      mockSession.pcParticipant = participantB as any;
+      statsAggregator['sendStats'](rtpStats, new Date());
+
+      expect(requestApiSpy).not.toHaveBeenCalled();
+    });
   });
 });