Skip to content

Commit feed24a

Browse files
Revert "Merge branch 'STREAM-1123-updating-tracks' into release/v12.0.0"
This reverts commit 46fa380, reversing changes made to 8e12a61.
1 parent 46fa380 commit feed24a

4 files changed

Lines changed: 4 additions & 7 deletions

File tree

changelog.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
### Breaking Changes
1313
* [STREAM-1178](https://inindca.atlassian.net/browse/STREAM-1178) - REVERT STREAM-825, removed ability to send multiple tracks when screensharing.
1414
* [STREAM-1130](https://inindca.atlassian.net/browse/STREAM-1130) - Updated TypeScript to v5.9.3 and Webpack to v5.105.0, removed legacy Spigot testing, added `.nvmrc`, demo app dependency updates, updated Node versions in testing matrices.
15-
* [STREAM-1123](https://inindca.atlassian.net/browse/STREAM-1123) - Only update necessary tracks when changing devices. Prevent virtual background from getting replaced
1615

1716
# [v11.5.1](https://github.com/MyPureCloud/genesys-cloud-webrtc-sdk/compare/v11.5.0...v11.5.1)
1817
### Added

src/client.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -524,11 +524,8 @@ export class GenesysCloudWebrtcSdk extends (EventEmitter as { new(): StrictEvent
524524
});
525525

526526
if ((updateVideo || updateAudio) && this.sessionManager) {
527-
const updateOptions: any = {};
528-
if (updateVideo) updateOptions.videoDeviceId = options.videoDeviceId;
529-
if (updateAudio) updateOptions.audioDeviceId = options.audioDeviceId;
530527
promises.push(
531-
this.sessionManager.updateOutgoingMediaForAllSessions(updateOptions)
528+
this.sessionManager.updateOutgoingMediaForAllSessions()
532529
);
533530
}
534531

src/sessions/session-manager.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,8 @@ export class SessionManager {
229229
const promises = sessions.map(session => {
230230
return this.updateOutgoingMedia({
231231
session,
232-
...opts
232+
videoDeviceId: opts.videoDeviceId,
233+
audioDeviceId: opts.audioDeviceId
233234
});
234235
});
235236
return Promise.all(promises);

test/unit/client.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,7 @@ describe('Client', () => {
825825
await sdk.updateDefaultDevices(options);
826826

827827
expect(sdk.headset.updateAudioInputDevice).toHaveBeenCalledWith(options.audioDeviceId);
828-
expect(sdk.sessionManager.updateOutgoingMediaForAllSessions).toHaveBeenCalledWith({"audioDeviceId": "new-audio-device-id"});
828+
expect(sdk.sessionManager.updateOutgoingMediaForAllSessions).toHaveBeenCalledWith();
829829
expect(sessionManagerMock.updateOutputDeviceForAllSessions).not.toHaveBeenCalled();
830830

831831
sessionManagerMock.updateOutgoingMediaForAllSessions.mockReset();

0 commit comments

Comments
 (0)