Skip to content

Commit 0be378a

Browse files
authored
Remove separate handling of secret parameters in RunActionModal (#1886)
fix: remove separate handling of secret parameters in RunActionModal because we already send secrets regardless of what's in the action
1 parent 082a7ba commit 0be378a

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/components/modals/RunActionModal.svelte

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,11 @@
4444
running = true;
4545
let secretParametersMap: ActionParametersMap = {};
4646
let nonSecretParametersMap: ActionParametersMap = {};
47-
let hasSecrets = false;
4847
4948
// Filter out the secret params to send directly to the action server.
5049
for (const param of Object.keys(parametersMap)) {
5150
if (parametersMap[param].schema.type === 'secret') {
5251
secretParametersMap[param] = argumentsMap[param];
53-
hasSecrets = true;
5452
} else {
5553
nonSecretParametersMap[param] = argumentsMap[param];
5654
}
@@ -66,10 +64,6 @@
6664
user,
6765
);
6866
69-
if (actionRunId !== null && hasSecrets) {
70-
await effects.sendActionSecretParameters(workspace, secretParametersMap, actionRunId, user);
71-
}
72-
7367
running = false;
7468
dispatch('complete', { actionRunId });
7569
}

0 commit comments

Comments
 (0)