Skip to content

Commit 236a511

Browse files
committed
Address PR issues from Bryan
1 parent 933ea97 commit 236a511

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/utilities/sequence-editor/from-seq-json.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ function seqJsonVariableToSequence(
120120
sequence += variables
121121
.map(variable => {
122122
const name = variable.name;
123-
const type = variable.type ? ' ' + variable.type : '';
123+
const type = variable.type ? ` ${variable.type}` : '';
124124
const enumName = variable.enum_name ? ' ' + variable.enum_name : '';
125125
const allowableRanges = variable.allowable_ranges
126126
? ` "${variable.allowable_ranges.map(range => `${range.min}...${range.max}`).join(',')}"`

src/utilities/sequence-editor/to-seq-json.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -567,8 +567,10 @@ function parseAllowableRanges(text: string, rangeNode: any): { max: number; min:
567567
const rangeMatch = /^([-+]?\d+)?(\.\.\.)([-+]?\d+)?$/.exec(range.replaceAll('"', '').trim());
568568
if (rangeMatch) {
569569
const [, min, , max] = rangeMatch;
570-
const maxNum = !isNaN(Number(max)) ? Number(max) : Infinity;
571-
const minNum = !isNaN(Number(min)) ? Number(min) : -Infinity;
570+
const parsedMaxNum = Number(max);
571+
const parsedMinNum = Number(min);
572+
const maxNum = !Number.isNaN(parsedMaxNum) ? parsedMaxNum : Infinity;
573+
const minNum = !Number.isNaN(parsedMinNum) ? parsedMinNum : -Infinity;
572574

573575
return { max: maxNum, min: minNum };
574576
}

0 commit comments

Comments
 (0)