add toasts for external dataset upload

duranb · duranb · commit 4b4c770c137f · 2024-10-21T14:54:30.000-07:00
diff --git a/src/utilities/effects.ts b/src/utilities/effects.ts
@@ -5747,12 +5747,14 @@ const effects = {
       const uploadedDatasetId = await reqGateway<number | null>('/uploadDataset', 'POST', body, user, true);
 
       if (uploadedDatasetId != null) {
+        showSuccessToast('External Dataset Uploaded Successfully');
         return uploadedDatasetId;
       }
 
-      return null;
+      throw Error('External Dataset Upload Failed');
     } catch (e) {
       catchError(e as Error);
+      showFailureToast('External Dataset Upload Failed');
       return null;
     }
   },

Original file line number	Diff line number	Diff line change
`@@ -5747,12 +5747,14 @@ const effects = {`
`5747`	`5747`	`const uploadedDatasetId = await reqGateway<number \| null>('/uploadDataset', 'POST', body, user, true);`
`5748`	`5748`
`5749`	`5749`	`if (uploadedDatasetId != null) {`
	`5750`	`+ showSuccessToast('External Dataset Uploaded Successfully');`
`5750`	`5751`	`return uploadedDatasetId;`
`5751`	`5752`	`}`
`5752`	`5753`
`5753`		`- return null;`
	`5754`	`+ throw Error('External Dataset Upload Failed');`
`5754`	`5755`	`} catch (e) {`
`5755`	`5756`	`catchError(e as Error);`
	`5757`	`+ showFailureToast('External Dataset Upload Failed');`
`5756`	`5758`	`return null;`
`5757`	`5759`	`}`
`5758`	`5760`	`},`