add toasts for external dataset upload

duranb · duranb · commit 4e6c26c8e2ca · 2024-10-22T13:11:04.000-07:00
diff --git a/src/utilities/effects.ts b/src/utilities/effects.ts
@@ -6391,12 +6391,14 @@ const effects = {
       const uploadedDatasetId = await reqGateway<number | null>('/uploadDataset', 'POST', body, user, true);
 
       if (uploadedDatasetId != null) {
+        showSuccessToast('External Dataset Uploaded Successfully');
         return uploadedDatasetId;
       }
 
-      return null;
+      throw Error('External Dataset Upload Failed');
     } catch (e) {
       catchError(e as Error);
+      showFailureToast('External Dataset Upload Failed');
       return null;
     }
   },

Original file line number	Diff line number	Diff line change
`@@ -6391,12 +6391,14 @@ const effects = {`
`6391`	`6391`	`const uploadedDatasetId = await reqGateway<number \| null>('/uploadDataset', 'POST', body, user, true);`
`6392`	`6392`
`6393`	`6393`	`if (uploadedDatasetId != null) {`
	`6394`	`+ showSuccessToast('External Dataset Uploaded Successfully');`
`6394`	`6395`	`return uploadedDatasetId;`
`6395`	`6396`	`}`
`6396`	`6397`
`6397`		`- return null;`
	`6398`	`+ throw Error('External Dataset Upload Failed');`
`6398`	`6399`	`} catch (e) {`
`6399`	`6400`	`catchError(e as Error);`
	`6401`	`+ showFailureToast('External Dataset Upload Failed');`
`6400`	`6402`	`return null;`
`6401`	`6403`	`}`
`6402`	`6404`	`},`