Merge pull request #606 from NOAA-EMC/Hang-Lei-NOAA-patch-3

Improve the developer workflow.
Prepare for release of 2.3.0

Author: Hang-Lei-NOAA

.github/workflows/developer.yml

@@ -41,7 +41,7 @@ jobs:
         sudo apt-get install doxygen
 
     - name: install-memory-dependencies
-      if: matrix.config == 'memory'      
+      if: matrix.config == 'memcheck'      
       run: |
         sudo apt-get install valgrind
 
@@ -73,7 +73,17 @@ jobs:
       run: |
         set -x
         export CC=gcc
-        cmake -S g2c -B g2c/build -DUSE_AEC=ON -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper -DBUILD_G2C=ON -DLOGGING=On -DPTHREADS=ON -DFTP_TEST_FILES=ON -DFTP_LARGE_TEST_FILES=OFF -DTEST_FILE_DIR=/home/runner/data -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS="-Werror -g -O0 -fsanitize=address -fno-omit-frame-pointer" 
+        cmake -S g2c -B g2c/build \
+          -DUSE_AEC=ON \
+          -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper \
+          -DBUILD_G2C=ON \
+          -DLOGGING=On \
+          -DPTHREADS=ON \
+          -DFTP_TEST_FILES=ON \
+          -DFTP_LARGE_TEST_FILES=OFF \
+          -DTEST_FILE_DIR=/home/runner/data \
+          -DCMAKE_BUILD_TYPE=Debug \
+          -DCMAKE_C_FLAGS="-g"
         cmake --build g2c/build --parallel 2 --verbose
         ctest --test-dir g2c/build --verbose --output-on-failure --rerun-failed
         
@@ -82,15 +92,35 @@ jobs:
       run: |
         set -x
         export CC=gcc
-        cmake -S g2c -B g2c/build -DUSE_AEC=ON -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper -DBUILD_G2C=ON -DLOGGING=On -DPTHREADS=ON -DFTP_TEST_FILES=ON -DFTP_LARGE_TEST_FILES=OFF -DTEST_FILE_DIR=/home/runner/data -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS="-Wall -Werror" 
+        cmake -S g2c -B g2c/build \
+          -DUSE_AEC=ON \
+          -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper \
+          -DBUILD_G2C=ON \
+          -DLOGGING=On \
+          -DPTHREADS=ON \
+          -DFTP_TEST_FILES=ON \
+          -DFTP_LARGE_TEST_FILES=OFF \
+          -DTEST_FILE_DIR=/home/runner/data \
+          -DCMAKE_BUILD_TYPE=Debug \
+          -DCMAKE_C_FLAGS="-g"
         cmake --build g2c/build --verbose
         
     - name: code_coverage
       if: matrix.config == 'code coverage'
       run: |
         set -x
         export CC=gcc
-        cmake -S g2c -B g2c/build -DUSE_AEC=ON -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper -DBUILD_G2C=ON -DLOGGING=On -DPTHREADS=ON -DFTP_TEST_FILES=ON -DFTP_LARGE_TEST_FILES=OFF -DTEST_FILE_DIR=/home/runner/data -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS="-g -fprofile-arcs -ftest-coverage -fprofile-abs-path -O0"
+        cmake -S g2c -B g2c/build \
+          -DUSE_AEC=ON \
+          -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper \
+          -DBUILD_G2C=ON \
+          -DLOGGING=On \
+          -DPTHREADS=ON \
+          -DFTP_TEST_FILES=ON \
+          -DFTP_LARGE_TEST_FILES=OFF \
+          -DTEST_FILE_DIR=/home/runner/data \
+          -DCMAKE_BUILD_TYPE=Debug \
+          -DCMAKE_C_FLAGS="-g"
         pwd
         cd g2c/build
         make VERBOSE=1
@@ -105,7 +135,16 @@ jobs:
       run: |
         set -x
         export LD_LIBRARY_PATH="/home/runner/jasper/lib:$LD_LIBRARY_PATH"
-        cmake -S g2c -B g2c/build -DUSE_AEC=ON -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper -DBUILD_G2C=ON -DLOGGING=On -DPTHREADS=ON -DFTP_TEST_FILES=ON -DTEST_FILE_DIR=/home/runner/data -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS="-g" 
+        cmake -S g2c -B g2c/build \
+          -DUSE_AEC=ON \
+          -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper \
+          -DBUILD_G2C=ON \
+          -DLOGGING=On \
+          -DPTHREADS=ON \
+          -DFTP_TEST_FILES=ON \
+          -DTEST_FILE_DIR=/home/runner/data \
+          -DCMAKE_BUILD_TYPE=Debug \
+          -DCMAKE_C_FLAGS="-g"
         cmake --build g2c/build --parallel 2 --verbose
         ctest --test-dir g2c/build
         ls -l g2c/build
@@ -115,7 +154,13 @@ jobs:
       run: |
         set -x
         export LD_LIBRARY_PATH="/home/runner/jasper/lib:$LD_LIBRARY_PATH"
-        cmake -S g2c -B g2c/build -DUSE_AEC=ON -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper -DBUILD_G2C=ON -DENABLE_DOCS=On -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS="-g" 
+        cmake -S g2c -B g2c/build \
+          -DUSE_AEC=ON \
+          -DJasper_ROOT=$GITHUB_WORKSPACE/nceplibs/jasper \
+          -DBUILD_G2C=ON \
+          -DENABLE_DOCS=On \
+          -DCMAKE_BUILD_TYPE=Debug \
+          -DCMAKE_C_FLAGS="-g"
         cmake --build g2c/build --parallel 2 --verbose
         ls -l g2c/build/docs/html
         
@@ -127,11 +172,19 @@ jobs:
         clang-format --version        
         find . -name '*.[ch]'|xargs clang-format -Werror --verbose --dry-run
         
-    - name: cache-data
+    - name: populate-data
       if: steps.cache-data.outputs.cache-hit != 'true'
       run: |
-        mkdir ~/data
-        cp $GITHUB_WORKSPACE/g2c/build/tests/data/* ~/data
+        # create data dir and copy test data into it.
+        # Prefer source test data (g2c/tests/data). Fall back to build/tests/data if present.
+        mkdir -p ~/data
+        if [ -d "$GITHUB_WORKSPACE/g2c/tests/data" ]; then
+          cp -r $GITHUB_WORKSPACE/g2c/tests/data/* ~/data
+        elif [ -d "$GITHUB_WORKSPACE/g2c/build/tests/data" ]; then
+          cp -r $GITHUB_WORKSPACE/g2c/build/tests/data/* ~/data
+        else
+          echo "Warning: no test data directory found at either $GITHUB_WORKSPACE/g2c/tests/data or $GITHUB_WORKSPACE/g2c/build/tests/data"
+        fi
         
     - name: upload-test-coverage
       if: matrix.config == 'code coverage'      

VERSION

@@ -1 +1 @@
-2.2.0
+2.3.0