Skip to content

Commit e04fd27

Browse files
committed
TODO optimization comment
1 parent 2f2e9c9 commit e04fd27

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

include/realizations/catchment/Bmi_Module_Formulation.hpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -689,7 +689,10 @@ namespace realization {
689689
//Figure out the c++ type to convert data to
690690
std::string type = get_bmi_model()->get_analogous_cxx_type(get_bmi_model()->GetVarType(param.first),
691691
varItemSize);
692-
692+
//TODO might consider refactoring as_vector and get_values_as_type
693+
//(and by extension, as_c_array) into the JSONProperty class
694+
//then instead of the PropertyVariant visitor filling vectors
695+
//it could fill the c-like array and avoid another copy.
693696
switch( param.second.get_type() ){
694697
case geojson::PropertyType::Natural:
695698
param.second.as_vector(long_vec);

0 commit comments

Comments
 (0)