refactor: performance improvement

amitguptagwl · amitguptagwl · commit 3dfcd20c8cff · 2026-03-16T19:15:44.000+05:30
diff --git a/src/xmlparser/DocTypeReader.js b/src/xmlparser/DocTypeReader.js
@@ -195,10 +195,11 @@ export default class DocTypeReader {
         }
         i++;
 
+        const startIndex = i;
         while (i < xmlData.length && xmlData[i] !== startChar) {
-            identifierVal += xmlData[i];
             i++;
         }
+        identifierVal = xmlData.substring(startIndex, i);
 
         if (xmlData[i] !== startChar) {
             throw new Error(`Unterminated ${type} value`);

Original file line number	Diff line number	Diff line change
`@@ -195,10 +195,11 @@ export default class DocTypeReader {`
`195`	`195`	`}`
`196`	`196`	`i++;`
`197`	`197`
	`198`	`+ const startIndex = i;`
`198`	`199`	`while (i < xmlData.length && xmlData[i] !== startChar) {`
`199`		`- identifierVal += xmlData[i];`
`200`	`200`	`i++;`
`201`	`201`	`}`
	`202`	`+ identifierVal = xmlData.substring(startIndex, i);`
`202`	`203`
`203`	`204`	`if (xmlData[i] !== startChar) {`
`204`	`205`	throw new Error(`Unterminated ${type} value`);