Skip to content

Commit 0b88ab0

Browse files
author
Norbert Nemeth
committed
Update custom alloyEditor button to work with SPA navigation
1 parent 891d628 commit 0b88ab0

File tree

4 files changed

+25
-22
lines changed

4 files changed

+25
-22
lines changed

modules/alloy-editor-custom-button-web/build.gradle

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,12 @@ buildscript {
1111
}
1212

1313
dependencies {
14-
compileOnly group: "com.liferay", name: "com.liferay.frontend.js.loader.modules.extender.api", version: "3.0.0"
15-
compileOnly group: "com.liferay.portal", name: "com.liferay.portal.kernel", version: "4.38.2"
16-
compileOnly group: "com.liferay.portal", name: "com.liferay.util.taglib", version: "4.0.8"
14+
compileOnly group: "com.liferay", name: "com.liferay.frontend.js.loader.modules.extender", version: "4.0.34"
15+
compileOnly group: "com.liferay", name: "com.liferay.frontend.js.loader.modules.extender.api", version: "3.2.10"
16+
compileOnly group: "com.liferay.portal", name: "com.liferay.portal.kernel", version: "4.60.1"
17+
compileOnly group: "com.liferay.portal", name: "com.liferay.util.taglib", version: "default"
1718
compileOnly group: "javax.portlet", name: "portlet-api", version: "3.0.0"
1819
compileOnly group: "javax.servlet", name: "javax.servlet-api", version: "3.0.1"
1920
compileOnly group: "jstl", name: "jstl", version: "1.2"
2021
compileOnly group: "org.osgi", name: "osgi.cmpn", version: "6.0.0"
21-
}
22-
23-
repositories {
24-
maven {
25-
url "https://repository-cdn.liferay.com/nexus/content/groups/public"
26-
}
2722
}

modules/alloy-editor-custom-button-web/src/main/java/com/liferay/frontend/editor/servlet/taglib/CustomButtonDynamicInclude.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,17 @@ public void include(
3838
HttpServletResponse httpServletResponse, String key)
3939
throws IOException {
4040

41-
ScriptData scriptData = new ScriptData();
41+
ScriptData scriptData = new ScriptData();
4242

43-
String buttonsCollection = _npmResolver.resolveModuleName(
44-
"frontend-editor-custom-button-web/main");
45-
46-
scriptData.append(
47-
null, "", buttonsCollection, ScriptData.ModulesType.ES6);
48-
49-
scriptData.writeTo(httpServletResponse.getWriter());
43+
String buttonsCollection = _npmResolver.resolveModuleName(
44+
"frontend-editor-custom-button-web/main");
45+
46+
scriptData.append(
47+
null,
48+
"main.default();", buttonsCollection + " as main",
49+
ScriptData.ModulesType.ES6);
50+
51+
scriptData.writeTo(httpServletResponse.getWriter());
5052
}
5153

5254
@Override
@@ -59,5 +61,4 @@ public void register(
5961

6062
@Reference
6163
private NPMResolver _npmResolver;
62-
63-
}
64+
}

modules/alloy-editor-custom-button-web/src/main/resources/META-INF/resources/buttons/ButtonMarquee.jsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,4 @@ class ButtonMarquee extends React.Component {
3232
}
3333
}
3434

35-
export default AlloyEditor.Base.ButtonActionStyle(AlloyEditor.Base.ButtonStateClasses(AlloyEditor.Base.ButtonStyle(ButtonMarquee))
36-
);
35+
export default ButtonMarquee;
Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
11
import ButtonMarquee from './buttons/ButtonMarquee';
22

3-
AlloyEditor.Buttons[ButtonMarquee.key] = AlloyEditor.ButtonMarquee = ButtonMarquee;
3+
export default function () {
4+
AlloyEditor.Buttons[
5+
ButtonMarquee.key
6+
] = AlloyEditor.ButtonMarquee = AlloyEditor.Base.ButtonActionStyle(
7+
AlloyEditor.Base.ButtonStateClasses(
8+
AlloyEditor.Base.ButtonStyle(ButtonMarquee)
9+
)
10+
);
11+
}

0 commit comments

Comments
 (0)