Skip to content

Commit 2426199

Browse files
authored
remove generic type parameter from logger interface (#104)
1 parent 4919660 commit 2426199

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nflx-spectator",
3-
"version": "3.0.12",
3+
"version": "3.0.13",
44
"license": "Apache-2.0",
55
"homepage": "https://github.com/Netflix/spectator-js",
66
"author": "Netflix Telemetry Engineering <netflix-atlas@googlegroups.com>",

src/logger/logger.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ const levels: Record<string, number> = {
77
fatal: 60
88
};
99

10-
export type Logger<T extends string | never = string> = {
10+
export type Logger = {
1111
trace: (message: string) => void;
1212
debug: (message: string) => void;
1313
info: (message: string) => void;
1414
warn: (message: string) => void;
1515
error: (message: string) => void;
1616
fatal: (message: string) => void;
17-
[key: string]: (message: T) => void;
17+
[key: string]: (message: string) => void;
1818
};
1919

2020
export function get_logger(level_name?: string): Logger {

test/logger/logger.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import {assert} from "chai";
22
import {get_logger, Logger} from "../../src/index.js";
33
import {describe, it} from "node:test";
4-
import { pino } from 'pino';
4+
import {pino} from 'pino';
55
import {once, sink} from 'pino-test';
66

77
describe("Logger Tests", (): void => {
88

99
it("integrate with pino", async (): Promise<void> => {
1010
const stream = sink();
11-
const log: Logger = pino({level: 'trace'}, stream);
11+
const log: Logger = pino({level: 'trace'}, stream) as Logger;
1212

1313
log.trace("trace");
1414
await once(stream, {level: 10, msg: 'trace'});

0 commit comments

Comments
 (0)