Performance improvements (#113)

* Update line protocol creation

* Update Copy

* Reuse Array

Author: ecbadeaux

src/meter/age_gauge.ts

@@ -16,12 +16,10 @@ export class AgeGauge extends Meter {
     }
 
     now(): Promise<void> {
-        const line = `${this._meter_type_symbol}:${this._id.spectatord_id}:0`
-        return this._writer.write(line);
+        return this._writer.write(this._line_prefix + "0");
     }
 
     set(seconds: number): Promise<void> {
-        const line = `${this._meter_type_symbol}:${this._id.spectatord_id}:${seconds}`
-        return this._writer.write(line);
+        return this._writer.write(this._line_prefix + seconds);
     }
 }

src/meter/counter.ts

@@ -18,8 +18,7 @@ export class Counter extends Meter {
 
     increment(amount: number = 1): Promise<void> {
         if (amount > 0) {
-            const line = `${this._meter_type_symbol}:${this._id.spectatord_id}:${amount}`
-            return this._writer.write(line);
+            return this._writer.write(this._line_prefix + amount);
         }
         return Promise.resolve();
     }

src/meter/dist_summary.ts

@@ -16,8 +16,7 @@ export class DistributionSummary extends Meter {
 
     record(amount: number): Promise<void> {
         if (amount >= 0) {
-            const line = `${this._meter_type_symbol}:${this._id.spectatord_id}:${amount}`
-            return this._writer.write(line);
+            return this._writer.write(this._line_prefix + amount);
         }
         return Promise.resolve();
     }

src/meter/gauge.ts

@@ -21,8 +21,7 @@ export class Gauge extends Meter {
     }
 
     set(value: number): Promise<void> {
-        const line = `${this._meter_type_symbol}:${this._id.spectatord_id}:${value}`
-        return this._writer.write(line);
+        return this._writer.write(this._line_prefix + value);
     }
 
     update(value: number): Promise<void> {

src/meter/id.ts

@@ -78,22 +78,13 @@ export class Id {
 
         let result: string = this.replace_invalid_chars(name);
 
-        const sorted_tags: {[k: string]: string} = Object.fromEntries(Object.entries(tags).sort(
-            (a: [string, string], b: [string, string]): number => {
-                const kSort: number = a[0].localeCompare(b[0]);
-                if (kSort != 0) {
-                    return kSort;
-                } else {
-                    return a[1].localeCompare(b[1]);
-                }
-            }
-        ));
-
-        Object.entries(sorted_tags).forEach(([k, v]: [string, string]): void => {
-            k = this.replace_invalid_chars(k);
-            v = this.replace_invalid_chars(v);
-            result += `,${k}=${v}`;
-        });
+        const sorted_entries = Object.entries(tags).sort(
+            (a, b) => a[0].localeCompare(b[0]) || a[1].localeCompare(b[1])
+        );
+
+        for (const [k, v] of sorted_entries) {
+            result += `,${this.replace_invalid_chars(k)}=${this.replace_invalid_chars(v)}`;
+        }
 
         return result;
     }
@@ -103,20 +94,19 @@ export class Id {
     }
 
     tags(): Tags {
-        return structuredClone(this._tags);
+        return {...this._tags};
     }
 
     with_tag(k: string, v: string): Id {
-        const new_tags: Tags = structuredClone(this._tags);
-        new_tags[k] = v;
+        const new_tags: Tags = {...this._tags, [k]: v};
         return new Id(this._name, new_tags);
     }
 
     with_tags(tags: Tags): Id {
         if (Object.keys(tags).length == 0) {
             return this;
         }
-        const new_tags = {...structuredClone(this._tags), ...tags};
+        const new_tags = {...this._tags, ...tags};
         return new Id(this._name, new_tags);
     }
 

src/meter/max_gauge.ts

@@ -13,8 +13,7 @@ export class MaxGauge extends Meter {
     }
 
     set(value: number): Promise<void> {
-        const line = `${this._meter_type_symbol}:${this._id.spectatord_id}:${value}`
-        return this._writer.write(line);
+        return this._writer.write(this._line_prefix + value);
     }
 
     update(value: number): Promise<void> {

src/meter/meter.ts

@@ -4,11 +4,13 @@ import {WriterUnion} from "../writer/new_writer.js";
 export abstract class Meter {
     protected _id: Id;
     protected _meter_type_symbol: string;
+    protected _line_prefix: string;
     protected readonly _writer: WriterUnion;
 
     protected constructor(id: Id, writer: WriterUnion, meter_type_symbol: string) {
         this._id = id;
         this._meter_type_symbol = meter_type_symbol;
+        this._line_prefix = `${meter_type_symbol}:${id.spectatord_id}:`;
         this._writer = writer;
     }
 

src/meter/monotonic_counter.ts

@@ -13,7 +13,6 @@ export class MonotonicCounter extends Meter {
     }
 
     set(amount: number): Promise<void> {
-        const line = `${this._meter_type_symbol}:${this._id.spectatord_id}:${amount}`
-        return this._writer.write(line);
+        return this._writer.write(this._line_prefix + amount);
     }
 }

src/meter/monotonic_counter_uint.ts

@@ -17,7 +17,6 @@ export class MonotonicCounterUint extends Meter {
     }
 
     set(amount: bigint): Promise<void> {
-        const line = `${this._meter_type_symbol}:${this._id.spectatord_id}:${BigInt.asUintN(64, amount)}`
-        return this._writer.write(line);
+        return this._writer.write(this._line_prefix + BigInt.asUintN(64, amount));
     }
 }

src/meter/percentile_dist_summary.ts

@@ -21,8 +21,7 @@ export class PercentileDistributionSummary extends Meter {
 
     record(amount: number): Promise<void> {
         if (amount >= 0) {
-            const line = `${this._meter_type_symbol}:${this._id.spectatord_id}:${amount}`
-            return this._writer.write(line);
+            return this._writer.write(this._line_prefix + amount);
         }
         return Promise.resolve();
     }