Version bump (#682)

* Version bump
* Fix spotbugs warnings
* Latest apache cxf seems to have fixed the connection pooling logic and also supports modern java
* Bump some of the easier npm dependencies. Leave major react + mseal bumps for later

Author: gmokki

.github/workflows/build.yaml

@@ -18,7 +18,7 @@ jobs:
     if: always()
     strategy:
       matrix:
-        java: [ '17', '21', '23' ]
+        java: [ '17', '21', '24' ]
     runs-on: ubuntu-latest
     steps:
       - name: Check out

CHANGELOG.md

@@ -4,6 +4,25 @@
 
 **Details**
 
+- `nflow-explorer`
+- Dependency updates
+  - Jetty 11.0.25
+  - Apache CFX 4.1.2
+  - logback 1.5.18
+  - jackson 2.19.0
+  - h2 2.2.224
+  - mssql-jdbc 12.10.0
+  - mariadb 3.5.3
+  - mysql-connector 9.3.0
+  - ojdbc11 23.8.0.25.04
+  - HikariCP 6.3.0
+  - joda-time 2.14.0
+  - slf4j 2.0.17
+  - reactor-netty 1.2.6
+  - reactor-core 3.7.6
+  - swagger 2.2.32
+  - asm 9.8
+
 ## 10.0.1 (2025-04-21)
 
 **Highlights**

findbugs-exclude.xml

@@ -11,6 +11,9 @@
   <Match>
     <Bug pattern="IMC_IMMATURE_CLASS_NO_EQUALS" />
   </Match>
+  <Match>
+    <Bug pattern="OPM_OVERLY_PERMISSIVE_METHOD" /> <!-- This is buggy in spotbugs 5.9 -->
+  </Match>
   <Match>
     <Bug pattern="AI_ANNOTATION_ISSUES_NEEDS_NULLABLE"/>
   </Match>

maven-version-rules.xml

@@ -113,6 +113,11 @@
                 <ignoreVersion type="regex">.*BETA.*</ignoreVersion>
             </ignoreVersions>
         </rule>
+        <rule groupId="io.projectreactor">
+            <ignoreVersions>
+                <ignoreVersion type="regex">.*M[0-9]</ignoreVersion>
+            </ignoreVersions>
+        </rule>
     </rules>
 </ruleset>
 

nflow-engine/src/main/java/io/nflow/engine/config/db/MariadbDatabaseConfiguration.java

@@ -45,8 +45,7 @@ public MariadbDatabaseConfiguration() {
    */
   @Bean
   @Override
-  @SuppressFBWarnings(value = { "WEM_WEAK_EXCEPTION_MESSAGING", "RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" },
-      justification = "exception message is ok, null-check in try-catch")
+  @SuppressFBWarnings(value = "WEM_WEAK_EXCEPTION_MESSAGING", justification = "exception message is ok")
   public DatabaseInitializer nflowDatabaseInitializer(@NFlow DataSource nflowDataSource, Environment env) {
     String scriptPrefix = "mariadb";
     try (Connection c = DataSourceUtils.getConnection(nflowDataSource)) {

nflow-engine/src/main/java/io/nflow/engine/config/db/MysqlDatabaseConfiguration.java

@@ -45,9 +45,7 @@ public MysqlDatabaseConfiguration() {
    */
   @Bean
   @Override
-  @SuppressFBWarnings(
-      value = { "WEM_WEAK_EXCEPTION_MESSAGING", "RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" },
-      justification = "exception message is ok, null-check in try-catch")
+  @SuppressFBWarnings(value = "WEM_WEAK_EXCEPTION_MESSAGING", justification = "exception message is ok")
   public DatabaseInitializer nflowDatabaseInitializer(@NFlow DataSource nflowDataSource, Environment env) {
     String scriptPrefix = "mysql";
     try (Connection c = DataSourceUtils.getConnection(nflowDataSource)) {

nflow-engine/src/main/java/io/nflow/engine/config/db/OracleDatabaseConfiguration.java

@@ -49,8 +49,7 @@ public OracleDatabaseConfiguration() {
    */
   @Bean
   @Override
-  @SuppressFBWarnings(value = { "WEM_WEAK_EXCEPTION_MESSAGING", "RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" },
-      justification = "exception message is ok, null-check in try-catch")
+  @SuppressFBWarnings(value = "WEM_WEAK_EXCEPTION_MESSAGING", justification = "exception message is ok")
   public DatabaseInitializer nflowDatabaseInitializer(@NFlow DataSource nflowDataSource, Environment env) {
     try (Connection c = DataSourceUtils.getConnection(nflowDataSource)) {
       DatabaseMetaData meta = c.getMetaData();

nflow-engine/src/main/java/io/nflow/engine/guice/EnvironmentModule.java

@@ -13,15 +13,12 @@
 
 import com.google.inject.AbstractModule;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 public class EnvironmentModule extends AbstractModule {
 
   private final Properties userProperties;
   private final String[] classpathPropertiesFiles;
 
-  @SuppressFBWarnings(value = "OPM_OVERLY_PERMISSIVE_METHOD", justification = "Public for Guice")
-  public EnvironmentModule(Properties userProperties, String... classpathPropertiesFiles) {
+  protected EnvironmentModule(Properties userProperties, String... classpathPropertiesFiles) {
     this.userProperties = userProperties;
     this.classpathPropertiesFiles = classpathPropertiesFiles;
   }

nflow-engine/src/main/java/io/nflow/engine/internal/dao/ExecutorDao.java

@@ -42,7 +42,6 @@
  * Use setter injection because constructor injection may not work when nFlow is used in some legacy systems.
  */
 @Component
-@SuppressFBWarnings(value = "SIC_INNER_SHOULD_BE_STATIC_ANON", justification = "common jdbctemplate practice")
 @Singleton
 public class ExecutorDao {
 
@@ -205,9 +204,6 @@ public void markRecovered(int recoveredExecutorId) {
     }
   }
 
-  @SuppressFBWarnings(
-      value = { "OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE", "SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING" },
-      justification = "spotbugs does not trust jdbctemplate, sql is constant in practice")
   public int deleteExpiredBefore(DateTime expiredBefore) {
     try {
       return jdbc.update("delete from nflow_executor where recovered is not null and " + sqlVariants.dateLtEqDiff("expires", "?")

nflow-engine/src/main/java/io/nflow/engine/internal/dao/HealthCheckDao.java

@@ -5,11 +5,9 @@
 
 import org.springframework.jdbc.core.JdbcTemplate;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.nflow.engine.config.NFlow;
 
 @Named
-@SuppressFBWarnings(value = "SIC_INNER_SHOULD_BE_STATIC_ANON", justification = "common jdbctemplate practice")
 public class HealthCheckDao {
   private final JdbcTemplate jdbc;
 
@@ -18,7 +16,6 @@ public HealthCheckDao(@NFlow JdbcTemplate jdbcTemplate) {
     this.jdbc = jdbcTemplate;
   }
 
-  @SuppressFBWarnings(value = "UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR", justification = "jdbc is injected")
   public void checkDatabaseConnection() {
     jdbc.query("select status, type from nflow_workflow where id = 0", resultSet -> null);
   }