fix: only set snapshot cheatcodes written flag when cheatcodes exist

Author: schaable

v-next/hardhat/src/internal/builtin-plugins/gas-analytics/snapshot-cheatcodes.ts

@@ -268,7 +268,11 @@ export async function checkSnapshotCheatcodes(
     previousSnapshotCheatcodes = await readSnapshotCheatcodes(basePath);
   } catch (error) {
     if (error instanceof FileNotFoundError) {
-      await writeSnapshotCheatcodes(basePath, snapshotCheatcodes);
+      // Only write if there are cheatcodes to save
+      const written = snapshotCheatcodes.size > 0;
+      if (written) {
+        await writeSnapshotCheatcodes(basePath, snapshotCheatcodes);
+      }
 
       return {
         passed: true,
@@ -277,7 +281,7 @@ export async function checkSnapshotCheatcodes(
           removed: [],
           changed: [],
         },
-        written: true,
+        written,
       };
     }
 

v-next/hardhat/test/internal/builtin-plugins/gas-analytics/tasks/solidity-test/task-action.ts

@@ -335,6 +335,25 @@ describe("solidity-test/task-action (override in gas-analytics/index)", () => {
         assert.deepEqual(cheatcodeContent, { "test-entry": "42" });
       });
 
+      it("should not write when no existing file and no cheatcodes in current run", async () => {
+        const suiteResults = [
+          createSuiteResult("MyContract", [
+            createTestResultWithSnapshots(undefined),
+          ]),
+        ];
+
+        const { snapshotCheatcodesCheck } = await handleSnapshotCheck(
+          tmpDir,
+          suiteResults,
+        );
+
+        assert.equal(snapshotCheatcodesCheck.passed, true);
+        assert.equal(snapshotCheatcodesCheck.written, false);
+        assert.equal(snapshotCheatcodesCheck.comparison.added.length, 0);
+        assert.equal(snapshotCheatcodesCheck.comparison.removed.length, 0);
+        assert.equal(snapshotCheatcodesCheck.comparison.changed.length, 0);
+      });
+
       it("should pass when snapshot cheatcodes are unchanged", async () => {
         const suiteResults = [
           createSuiteResult("MyContract", [