[MIG] l10n_it_delivery_note: Migration to 19.0

Author: Borruso

l10n_it_delivery_note/README.rst

@@ -21,13 +21,13 @@ ITA - Documento di trasporto
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github
-    :target: https://github.com/OCA/l10n-italy/tree/18.0/l10n_it_delivery_note
+    :target: https://github.com/OCA/l10n-italy/tree/19.0/l10n_it_delivery_note
     :alt: OCA/l10n-italy
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/l10n-italy-18-0/l10n-italy-18-0-l10n_it_delivery_note
+    :target: https://translation.odoo-community.org/projects/l10n-italy-19-0/l10n-italy-19-0-l10n_it_delivery_note
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -48,8 +48,8 @@ installed together.
 
 There are two available settings:
 
-- Base (default): one picking, one DN.
-- Advanced: more picking in one DN.
+-  Base (default): one picking, one DN.
+-  Advanced: more picking in one DN.
 
 **Italiano**
 
@@ -66,8 +66,8 @@ Non è possibile avere installati contemporaneamente ``l10n_it_ddt`` e
 
 Ci sono due impostazioni possibili.
 
-- Base (predefinita): un prelievo, un DDT.
-- Avanzata: più prelievi in un DDT.
+-  Base (predefinita): un prelievo, un DDT.
+-  Avanzata: più prelievi in un DDT.
 
 **Table of contents**
 
@@ -100,11 +100,14 @@ To configure this module, go to:
    In delivery note type you can specify if the product price have to be
    printed in the delivery note report/slip.
 
-   - *Inventory → Configuration → Delivery Notes → Conditions of
-     Transport*
-   - *Inventory → Configuration → Delivery Notes → Appearances of Goods*
-   - *Inventory → Configuration → Delivery Notes → Reasons of Transport*
-   - *Inventory → Configuration → Delivery Notes → Methods of Transport*
+   -  *Inventory → Configuration → Delivery Notes → Conditions of
+      Transport*
+   -  *Inventory → Configuration → Delivery Notes → Appearances of
+      Goods*
+   -  *Inventory → Configuration → Delivery Notes → Reasons of
+      Transport*
+   -  *Inventory → Configuration → Delivery Notes → Methods of
+      Transport*
 
 3. *Settings → User & Companies → Users*
 
@@ -142,10 +145,10 @@ Funzionalità avanzata
 
 Vengono attivate varie funzionalità aggiuntive:
 
-- più prelievi per un DDT
-- selezione multipla di prelievi e generazione dei DDT
-- aggiunta righe nota e righe sezione descrittive.
-- lista dei DDT.
+-  più prelievi per un DDT
+-  selezione multipla di prelievi e generazione dei DDT
+-  aggiunta righe nota e righe sezione descrittive.
+-  lista dei DDT.
 
 Il report DDT stampa in righe aggiuntive i lotti/seriali e le scadenze
 del prodotto.
@@ -170,7 +173,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-italy/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_delivery_note%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_delivery_note%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -187,39 +190,39 @@ Authors
 Contributors
 ------------
 
-- Riccardo Bellanova <r.bellanova@apuliasoftware.it>
+-  Riccardo Bellanova <r.bellanova@apuliasoftware.it>
 
-- Matteo Bilotta <mbilotta@linkeurope.it>
+-  Matteo Bilotta <mbilotta@linkeurope.it>
 
-- Giuseppe Borruso <gborruso@dinamicheaziendali.it>
+-  Giuseppe Borruso <gborruso@dinamicheaziendali.it>
 
-- Marco Calcagni <mcalcagni@dinamicheaziendali.it>
+-  Marco Calcagni <mcalcagni@dinamicheaziendali.it>
 
-- Marco Colombo <marco.colombo@gmail.com>
+-  Marco Colombo <marco.colombo@gmail.com>
 
-- Gianmarco Conte <gconte@dinamicheaziendali.it>
+-  Gianmarco Conte <gconte@dinamicheaziendali.it>
 
-- Letizia Freda <letizia.freda@netfarm.it>
+-  Letizia Freda <letizia.freda@netfarm.it>
 
-- Andrea Piovesana <andrea.m.piovesana@gmail.com>
+-  Andrea Piovesana <andrea.m.piovesana@gmail.com>
 
-- Alex Comba <alex.comba@agilebg.com>
+-  Alex Comba <alex.comba@agilebg.com>
 
-- `Ooops <https://www.ooops404.com>`__:
+-  `Ooops <https://www.ooops404.com>`__:
 
-     - Giovanni Serra <giovanni@gslab.it>
-     - Foresti Francesco <francesco.foresti@ooops404.com>
+      -  Giovanni Serra <giovanni@gslab.it>
+      -  Foresti Francesco <francesco.foresti@ooops404.com>
 
-- Nextev Srl <odoo@nextev.it>
+-  Nextev Srl <odoo@nextev.it>
 
-- `PyTech-SRL <https://www.pytech.it>`__:
+-  `PyTech-SRL <https://www.pytech.it>`__:
 
-     - Alessandro Uffreduzzi <alessandro.uffreduzzi@pytech.it>
-     - Sebastiano Picchi <sebastiano.picchi@pytech.it>
+      -  Alessandro Uffreduzzi <alessandro.uffreduzzi@pytech.it>
+      -  Sebastiano Picchi <sebastiano.picchi@pytech.it>
 
-- `Aion Tech <https://aiontech.company/>`__:
+-  `Aion Tech <https://aiontech.company/>`__:
 
-  - Simone Rubino <simone.rubino@aion-tech.it>
+   -  Simone Rubino <simone.rubino@aion-tech.it>
 
 Maintainers
 -----------
@@ -248,6 +251,6 @@ Current `maintainers <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-MarcoCalcagni| |maintainer-aleuffre| |maintainer-renda-dev| 
 
-This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/18.0/l10n_it_delivery_note>`_ project on GitHub.
+This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/19.0/l10n_it_delivery_note>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

l10n_it_delivery_note/__manifest__.py

@@ -13,7 +13,7 @@
     "author": "Marco Calcagni, Gianmarco Conte, Link IT Europe Srl, "
     "Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/l10n-italy",
-    "version": "18.0.1.0.4",
+    "version": "19.0.1.0.0",
     "category": "Localization/Italy",
     "license": "AGPL-3",
     "maintainers": ["MarcoCalcagni", "aleuffre", "renda-dev"],

l10n_it_delivery_note/controllers/portal.py

@@ -1,26 +1,26 @@
 from odoo.exceptions import AccessError, MissingError
+from odoo.fields import Domain
 from odoo.http import request, route
-from odoo.osv.expression import OR
 
 from odoo.addons.portal.controllers.portal import CustomerPortal
 from odoo.addons.portal.controllers.portal import pager as portal_pager
 
 
 class DNCustomerPortal(CustomerPortal):
     def _get_delivery_note_domain(self):
-        domain = [("state", "in", ["confirm", "invoiced", "done"])]
-        return domain
+        return Domain("state", "in", ["confirm", "invoiced", "done"])
 
     def _prepare_home_portal_values(self, counters):
         values = super()._prepare_home_portal_values(counters)
-        dn_count = (
-            request.env["stock.delivery.note"].search_count(
-                self._get_delivery_note_domain()
+        if "dn_count" in counters:
+            dn_count = (
+                request.env["stock.delivery.note"].search_count(
+                    self._get_delivery_note_domain()
+                )
+                if request.env["stock.delivery.note"].has_access("read")
+                else 0
             )
-            if request.env["stock.delivery.note"].has_access("read")
-            else 0
-        )
-        values["dn_count"] = dn_count
+            values["dn_count"] = dn_count
         return values
 
     def _get_delivery_notes_searchbar_sortings(self):
@@ -61,13 +61,13 @@ def _prepare_my_delivery_notes_values(
         domain = self._get_delivery_note_domain()
 
         if date_begin and date_end:
-            domain += [("date", ">", date_begin), ("date", "<=", date_end)]
+            domain &= Domain([("date", ">", date_begin), ("date", "<=", date_end)])
 
         if search and search_in:
             search_domain = []
             if search_in == "name":
-                search_domain = OR([search_domain, [("name", "ilike", search)]])
-            domain += search_domain
+                search_domain = Domain.OR([search_domain, [("name", "ilike", search)]])
+            domain &= Domain(search_domain)
 
         pager_values = portal_pager(
             url=url,

l10n_it_delivery_note/mixins/delivery_mixin.py

@@ -9,26 +9,10 @@ def _default_volume_uom(model):
     return model.env.ref("uom.product_uom_litre", raise_if_not_found=False)
 
 
-def _domain_volume_uom(model):
-    uom_category_id = model.env.ref(
-        "uom.product_uom_categ_vol", raise_if_not_found=False
-    )
-
-    return [("category_id", "=", uom_category_id.id)]
-
-
 def _default_weight_uom(model):
     return model.env.ref("uom.product_uom_kgm", raise_if_not_found=False)
 
 
-def _domain_weight_uom(model):
-    uom_category_id = model.env.ref(
-        "uom.product_uom_categ_kgm", raise_if_not_found=False
-    )
-
-    return [("category_id", "=", uom_category_id.id)]
-
-
 class DeliveryData(models.AbstractModel):
     _name = "l10n_it_delivery_note.delivery_mixin"
     _description = "Common data for records to be delivered"
@@ -56,26 +40,23 @@ class DeliveryData(models.AbstractModel):
     delivery_volume_uom_id = fields.Many2one(
         "uom.uom",
         string="Volume of Delivery UoM",
-        default=_default_volume_uom,
-        domain=_domain_volume_uom,
+        default=lambda self: self._default_volume_uom(),
     )
     delivery_volume = fields.Float(
         string="Volume of Delivery",
     )
     delivery_gross_weight_uom_id = fields.Many2one(
         "uom.uom",
         string="Gross Weight of Delivery UoM",
-        default=_default_weight_uom,
-        domain=_domain_weight_uom,
+        default=lambda self: self._default_weight_uom(),
     )
     delivery_gross_weight = fields.Float(
         string="Gross Weight of Delivery",
     )
     delivery_net_weight_uom_id = fields.Many2one(
         "uom.uom",
         string="Net Weight of Delivery UoM",
-        default=_default_weight_uom,
-        domain=_domain_weight_uom,
+        default=lambda self: self._default_weight_uom(),
     )
     delivery_net_weight = fields.Float(
         string="Net Weight of Delivery",

l10n_it_delivery_note/models/account_invoice.py

@@ -7,6 +7,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 from odoo import fields, models
+from odoo.fields import Domain
 
 from .stock_delivery_note import DATE_FORMAT, DOMAIN_INVOICE_STATUSES
 
@@ -37,7 +38,7 @@ def goto_delivery_notes(self, **kwargs):
         action.update(kwargs)
 
         if len(delivery_notes) > 1:
-            action["domain"] = [("id", "in", delivery_notes.ids)]
+            action["domain"] = Domain("id", "in", delivery_notes.ids)
 
         elif len(delivery_notes) == 1:
             action["views"] = [
@@ -78,11 +79,11 @@ def _prepare_note_dn_value(self, sequence, delivery_note_id):
         return {
             "sequence": sequence,
             "display_type": "line_note",
-            "name": self.env._("""Delivery Note "%(ddt_name)s" of %(ddt_date)s""")
-            % {
-                "ddt_name": delivery_note_id.name,
-                "ddt_date": delivery_note_id.date.strftime(DATE_FORMAT),
-            },
+            "name": self.env._(
+                """Delivery Note "%(ddt_name)s" of %(ddt_date)s""",
+                ddt_name=delivery_note_id.name,
+                ddt_date=delivery_note_id.date.strftime(DATE_FORMAT),
+            ),
             "note_dn": True,
             "delivery_note_id": delivery_note_id.id,
             "quantity": 0,

l10n_it_delivery_note/models/res_config_settings.py

@@ -20,7 +20,7 @@ def _default_virtual_locations_root(self):
     virtual_locations_root = fields.Many2one(
         "stock.location",
         string="Virtual locations root",
-        default=_default_virtual_locations_root,
+        default=lambda self: self._default_virtual_locations_root(),
         config_parameter="stock.location.virtual_root",
     )
 

l10n_it_delivery_note/models/sale_order.py

@@ -2,6 +2,7 @@
 # @author: Matteo Bilotta <mbilotta@linkeurope.it>
 
 from odoo import api, fields, models
+from odoo.fields import Command, Domain
 
 from .stock_delivery_note import DOMAIN_DELIVERY_NOTE_STATES, DOMAIN_INVOICE_STATUSES
 
@@ -112,7 +113,11 @@ def _assign_delivery_notes_invoices(self, invoice_ids):
                 if invoice_id in invoice_ids
             ]
             ready_delivery_note.write(
-                {"invoice_ids": [(4, invoice_id) for invoice_id in ready_invoice_ids]}
+                {
+                    "invoice_ids": [
+                        Command.link(invoice_id) for invoice_id in ready_invoice_ids
+                    ]
+                }
             )
 
         ready_delivery_notes._compute_invoice_status()
@@ -137,7 +142,7 @@ def goto_delivery_notes(self, **kwargs):
         action.update(kwargs)
 
         if len(delivery_notes) > 1:
-            action["domain"] = [("id", "in", delivery_notes.ids)]
+            action["domain"] = Domain("id", "in", delivery_notes.ids)
 
         elif len(delivery_notes) == 1:
             action["views"] = [