[MIG] l10n_it_withholding_tax_payment: Migration to 16.0

Co-authored-by:  Simone Rubino <simone.rubino@aion-tech.it>

Author: matteo.tognini

l10n_it_withholding_tax_payment/__manifest__.py

@@ -5,7 +5,7 @@
 {
     "name": "ITA - Ritenuta d'acconto - Pagamenti",
     "summary": "Gestisce le ritenute sulle fatture e sui pagamenti",
-    "version": "14.0.1.0.2",
+    "version": "16.0.1.0.1",
     "development_status": "Beta",
     "category": "Localization/Italy",
     "website": "https://github.com/OCA/l10n-italy",

l10n_it_withholding_tax_payment/models/withholding_tax.py

@@ -38,7 +38,7 @@ def check_unlink(self):
                 )
             )
 
-        super().check_unlink()
+        return super().check_unlink()
 
 
 class WithholdingTaxMovePayment(models.Model):
@@ -69,8 +69,8 @@ def _compute_total(self):
         required=True,
         default=lambda self: self.env.company,
     )
-    name = fields.Char("Name")
-    date = fields.Date(string="Date")
+    name = fields.Char()
+    date = fields.Date()
     date_payment = fields.Date("Payment Date")
     date_start = fields.Date("Start Date", readonly=True)
     date_stop = fields.Date("Stop Date", readonly=True)

l10n_it_withholding_tax_payment/readme/CONTRIBUTORS.rst

@@ -1,3 +1,7 @@
 * Alessandro Camilli <alessandrocamilli@openforce.it>
 * Lorenzo Battistini <lorenzo.battistini@agilebg.com>
 * Matteo Bilotta <mbilotta@linkgroup.it>
+* Nextev <web@nextev.it>
+* `Aion Tech <https://aiontech.company/>`_:
+
+  * Simone Rubino <simone.rubino@aion-tech.it>

l10n_it_withholding_tax_payment/security/security.xml

@@ -2,17 +2,13 @@
 <!--
     Copyright 2019 Matteo Bilotta
   -->
-<odoo>
-    <data noupdate="1">
-
-        <record id="withholding_tax_payment_comp_rule" model="ir.rule">
-            <field name="name">Withholding Tax Payment Move</field>
-            <field name="model_id" ref="model_withholding_tax_move_payment" />
-            <field name="global" eval="True" />
-            <field
-                name="domain_force"
-            >['|',('company_id','=',False),('company_id','in',company_ids)]</field>
-        </record>
-
-    </data>
+<odoo noupdate="1">
+    <record id="withholding_tax_payment_comp_rule" model="ir.rule">
+        <field name="name">Withholding Tax Payment Move</field>
+        <field name="model_id" ref="model_withholding_tax_move_payment" />
+        <field name="global" eval="True" />
+        <field
+            name="domain_force"
+        >['|',('company_id','=',False),('company_id','in',company_ids)]</field>
+    </record>
 </odoo>

l10n_it_withholding_tax_payment/tests/test_withholding_tax_payment.py

@@ -1,4 +1,5 @@
 #  Copyright 2021 Simone Rubino - Agile Business Group
+#  Copyright 2023 Simone Rubino - Aion Tech
 #  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 from odoo.tests import Form, tagged
@@ -39,7 +40,9 @@ def setup_withholding_data(cls, company_data):
         """
         cls.set_allowed_companies(company_data["company"])
         wh_tax = cls.setup_withholding_tax(company_data)
-        invoice = cls.init_invoice("in_invoice", amounts=[100])
+        invoice = cls.init_invoice(
+            "in_invoice", amounts=[100], company=company_data["company"]
+        )
         invoice_form = Form(invoice)
         with invoice_form.invoice_line_ids.edit(0) as line_form:
             line_form.invoice_line_tax_wt_ids.clear()
@@ -56,7 +59,9 @@ def set_allowed_companies(cls, company):
         """
         context = {"allowed_company_ids": company.ids}
         if "allowed_company_ids" in cls.env.context:
-            cls.env.context.pop("allowed_company_ids")
+            ctx = dict(cls.env.context)
+            ctx.pop("allowed_company_ids")
+            cls.env.context = ctx
         cls.env.context = dict(**cls.env.context, **context)
 
     @classmethod
@@ -91,7 +96,10 @@ def generate_withholding_tax_payment(self, invoice):
         )
         wh_tax_payment_wizard = (
             self.env["wizard.wt.move.payment.create"]
-            .with_context(active_model=wh_tax_move._name, active_ids=wh_tax_move.ids)
+            .with_context(
+                active_model=wh_tax_move._name,
+                active_ids=wh_tax_move.ids,
+            )
             .create({})
         )
         wh_tax_payment_action = wh_tax_payment_wizard.generate()

l10n_it_withholding_tax_payment/views/withholding_tax.xml

@@ -37,7 +37,7 @@
             <field name="name">withholding.tax.move.payment.view.tree</field>
             <field name="model">withholding.tax.move.payment</field>
             <field name="arch" type="xml">
-                <tree string="Withholding Payment Move">
+                <tree>
                     <field name="name" />
                     <field name="date" />
                     <field name="date_start" />
@@ -72,6 +72,7 @@
                         string="Create Account Move"
                         type="object"
                         attrs="{'invisible': ['|', ('state', '!=', 'confirmed'), ('move_id', '!=', False)]}"
+                        class="oe_highlight"
                     />
                         <field
                         name="state"
@@ -80,8 +81,10 @@
                     />
                     </header>
                     <sheet string="Withholding Payment Move">
+                        <div class="oe_title">
+                            <h1><field name="name" readonly="1" /></h1>
+                        </div>
                         <group>
-                            <field name="name" />
                             <field name="date" />
                             <field
                             name="company_id"
@@ -96,10 +99,22 @@
                                 <field name="date_stop" />
                             </group>
                             <group string="Account Setting">
-                                <field name="date_payment" />
-                                <field name="journal_id" />
-                                <field name="account_id" />
-                                <field name="move_id" />
+                                <field
+                                name="date_payment"
+                                required="1"
+                                attrs="{'readonly': [('state', '=', 'confirmed')]}"
+                            />
+                                <field
+                                name="journal_id"
+                                required="1"
+                                attrs="{'readonly': [('state', '=', 'confirmed')]}"
+                            />
+                                <field
+                                name="account_id"
+                                required="1"
+                                attrs="{'readonly': [('state', '=', 'confirmed')]}"
+                            />
+                                <field name="move_id" readonly="1" />
                             </group>
                         </group>
                         <newline />

l10n_it_withholding_tax_payment/wizard/create_move_payment.py

@@ -25,10 +25,10 @@ def _default_wt_moves(self):
     def generate(self):
         wt_move_payment_obj = self.env["withholding.tax.move.payment"]
         wt_payment = wt_move_payment_obj.generate_from_moves(self.wt_move_ids)
-        view = self.env["ir.model.data"].get_object_reference(
-            "l10n_it_withholding_tax_payment", "view_withholding_move_payment_form"
+        view = self.env["ir.model.data"]._xmlid_lookup(
+            "l10n_it_withholding_tax_payment.view_withholding_move_payment_form"
         )
-        view_id = view[1] or False
+        view_id = view[2] or False
 
         return {
             "name": _("Withholding Tax Payment"),