[MIG] l10n_it_fiscal_document_type: Migration to 16.0

Author: TheMule71

l10n_it_fiscal_document_type/README.rst

@@ -14,13 +14,13 @@ ITA - Tipi di documento fiscale per dichiarativi
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github
-    :target: https://github.com/OCA/l10n-italy/tree/14.0/l10n_it_fiscal_document_type
+    :target: https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_fiscal_document_type
     :alt: OCA/l10n-italy
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fiscal_document_type
+    :target: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_fiscal_document_type
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
-    :target: https://runbot.odoo-community.org/runbot/122/14.0
+    :target: https://runbot.odoo-community.org/runbot/122/16.0
     :alt: Try me on Runbot
 
 |badge1| |badge2| |badge3| |badge4| |badge5| 
@@ -59,7 +59,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-italy/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_fiscal_document_type%0Aversion:%2014.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_fiscal_document_type%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -79,6 +79,7 @@ Contributors
 * Gianmarco Conte <gconte@dinamicheaziendali.it>
 * Sergio Zanchetta <https://github.com/primes2h>
 * Alfredo Zamora <alfredo.zamora@agilebg.com>
+* Marco Colombo <marco.colombo@phi.technology>
 
 Other credits
 ~~~~~~~~~~~~~
@@ -100,6 +101,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/14.0/l10n_it_fiscal_document_type>`_ project on GitHub.
+This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_fiscal_document_type>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

l10n_it_fiscal_document_type/__manifest__.py

@@ -2,11 +2,12 @@
 # Copyright 2018 Sergio Zanchetta (Associazione PNLUG - Gruppo Odoo)
 # Copyright 2018 Lorenzo Battistini (https://github.com/eLBati)
 # Copyright 2021 Andrea Cometa (https://www.apuliasoftware.it)
+# Copyright 2022 Marco Colombo (<marco.colombo@phi.technology>
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 {
     "name": "ITA - Tipi di documento fiscale per dichiarativi",
-    "version": "14.0.1.1.1",
+    "version": "16.0.1.0.0",
     "category": "Localization/Italy",
     "author": "Link It srl, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/l10n-italy",

l10n_it_fiscal_document_type/migrations/13.0.1.0.0/post-migration.py

@@ -84,9 +84,10 @@ def _get_document_fiscal_type(
         readonly=False,
     )
 
-    def _reverse_move_vals(self, default_values, cancel=True):
-        vals = super()._reverse_move_vals(default_values, cancel)
-        # when reversing a move, fiscal_document_type_id should be recomputed, not copied
-        if "fiscal_document_type_id" in vals:
-            del vals["fiscal_document_type_id"]
-        return vals
+    def _reverse_moves(self, default_values_list=None, cancel=False):
+        reverse_moves = super()._reverse_moves(
+            default_values_list=default_values_list, cancel=cancel
+        )
+        reverse_moves.update({"fiscal_document_type_id": False})
+        reverse_moves._compute_set_document_fiscal_type()
+        return reverse_moves

l10n_it_fiscal_document_type/models/account_move.py

@@ -4,14 +4,15 @@
 class FiscalDocumentType(models.Model):
     _name = "fiscal.document.type"
     _description = "Fiscal document type"
+    _rec_names_search = ["name", "code"]
 
-    code = fields.Char(string="Code", size=5, required=True)
-    name = fields.Char(string="Name", size=100, required=True)
+    code = fields.Char(size=5, required=True)
+    name = fields.Char(size=100, required=True)
     out_invoice = fields.Boolean(string="Customer Invoice")
     in_invoice = fields.Boolean(string="Vendor Bill")
     out_refund = fields.Boolean(string="Customer Credit Note")
     in_refund = fields.Boolean(string="Vendor Credit Note")
-    priority = fields.Integer(string="Priority", default="3")
+    priority = fields.Integer(default="3")
 
     journal_ids = fields.Many2many(
         "account.journal",
@@ -27,9 +28,9 @@ class FiscalDocumentType(models.Model):
 
     _order = "code, priority asc"
 
-    @api.model
-    def create(self, vals):
-        res = super(FiscalDocumentType, self).create(vals)
+    @api.model_create_multi
+    def create(self, vals_list):
+        res = super(FiscalDocumentType, self).create(vals_list)
         res.journal_ids.check_doc_type_relation()
         return res
 
@@ -44,16 +45,3 @@ def name_get(self):
         for doc_type in self:
             res.append((doc_type.id, "[%s] %s" % (doc_type.code, doc_type.name)))
         return res
-
-    @api.model
-    def name_search(self, name="", args=None, operator="ilike", limit=100):
-        if not args:
-            args = []
-        if name:
-            records = self.search(
-                ["|", ("name", operator, name), ("code", operator, name)] + args,
-                limit=limit,
-            )
-        else:
-            records = self.search(args, limit=limit)
-        return records.name_get()

l10n_it_fiscal_document_type/models/fiscal_document_type.py

@@ -13,8 +13,8 @@ def check_doc_type_relation(self):
             if len(docs) > 1:
                 raise UserError(
                     _(
-                        "Journal %s can be linked to only 1 fiscal document "
-                        "type (found in %s)"
+                        "Journal %(name)s can be linked to only 1 fiscal document "
+                        "type (found in %(spec)s)"
                     )
-                    % (journal.name, ", ".join([d.code for d in docs]))
+                    % {"name": journal.name, "spec": ", ".join([d.code for d in docs])}
                 )

l10n_it_fiscal_document_type/models/journal.py

@@ -6,9 +6,7 @@ class ResPartner(models.Model):
 
     out_fiscal_document_type = fields.Many2one(
         "fiscal.document.type",
-        string="Out Fiscal Document Type",
     )
     in_fiscal_document_type = fields.Many2one(
         "fiscal.document.type",
-        string="In Fiscal Document Type",
     )

l10n_it_fiscal_document_type/models/res_partner.py

@@ -3,3 +3,4 @@
 * Gianmarco Conte <gconte@dinamicheaziendali.it>
 * Sergio Zanchetta <https://github.com/primes2h>
 * Alfredo Zamora <alfredo.zamora@agilebg.com>
+* Marco Colombo <marco.colombo@phi.technology>

l10n_it_fiscal_document_type/readme/CONTRIBUTORS.rst

@@ -3,7 +3,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
+<meta name="generator" content="Docutils: http://docutils.sourceforge.net/" />
 <title>ITA - Tipi di documento fiscale per dichiarativi</title>
 <style type="text/css">
 
@@ -367,7 +367,7 @@ <h1 class="title">ITA - Tipi di documento fiscale per dichiarativi</h1>
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/l10n-italy/tree/14.0/l10n_it_fiscal_document_type"><img alt="OCA/l10n-italy" src="https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fiscal_document_type"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/122/14.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_fiscal_document_type"><img alt="OCA/l10n-italy" src="https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_fiscal_document_type"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/122/16.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p>
 <p><strong>Italiano</strong></p>
 <p>Tabella con codici tipo documento previsti dall’Agenzia delle Entrate.</p>
 <p><strong>English</strong></p>
@@ -400,7 +400,7 @@ <h1><a class="toc-backref" href="#id2">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-italy/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_fiscal_document_type%0Aversion:%2014.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_fiscal_document_type%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -419,6 +419,7 @@ <h2><a class="toc-backref" href="#id5">Contributors</a></h2>
 <li>Gianmarco Conte &lt;<a class="reference external" href="mailto:gconte&#64;dinamicheaziendali.it">gconte&#64;dinamicheaziendali.it</a>&gt;</li>
 <li>Sergio Zanchetta &lt;<a class="reference external" href="https://github.com/primes2h">https://github.com/primes2h</a>&gt;</li>
 <li>Alfredo Zamora &lt;<a class="reference external" href="mailto:alfredo.zamora&#64;agilebg.com">alfredo.zamora&#64;agilebg.com</a>&gt;</li>
+<li>Marco Colombo &lt;<a class="reference external" href="mailto:marco.colombo&#64;phi.technology">marco.colombo&#64;phi.technology</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="other-credits">
@@ -435,7 +436,7 @@ <h2><a class="toc-backref" href="#id7">Maintainers</a></h2>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-italy/tree/14.0/l10n_it_fiscal_document_type">OCA/l10n-italy</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_fiscal_document_type">OCA/l10n-italy</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

l10n_it_fiscal_document_type/static/description/index.html

@@ -107,6 +107,7 @@ def test_doc_type_on_invoice_create(self):
                 {
                     "reason": "no reason",
                     "refund_method": "cancel",
+                    "journal_id": invoice.journal_id.id,
                 }
             )
         )
@@ -125,7 +126,7 @@ def _set_recompute_document_type(self, invoice, doc_type):
 
         # Recompute document type for the invoice
         self.env.add_to_compute(invoice._fields["fiscal_document_type_id"], invoice)
-        self.inv_model.flush()
+        self.inv_model.flush_model()
         return invoice
 
     def test_keep_edited_invoice(self):